New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParamSpec bindings #352

Merged
merged 3 commits into from Jul 9, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Jul 6, 2018

No description provided.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 6, 2018

Member

For some reason things like g_param_spec_bool, g_param_spec_int, etc (all the constructors) are not generated by GIR. Not sure yet why, @EPashkin do you have an idea? If not, I'll look later, don't spend time on it unless you want to :)

Also how would we best override the get_type function? Configuration that takes a string, and that is just put there instead of whatever the GIR says?

Member

sdroege commented Jul 6, 2018

For some reason things like g_param_spec_bool, g_param_spec_int, etc (all the constructors) are not generated by GIR. Not sure yet why, @EPashkin do you have an idea? If not, I'll look later, don't spend time on it unless you want to :)

Also how would we best override the get_type function? Configuration that takes a string, and that is just put there instead of whatever the GIR says?

Show outdated Hide outdated Gir_GObject.toml
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 6, 2018

Member

IMHO config string get_type: Option<String> is enough

Member

EPashkin commented Jul 6, 2018

IMHO config string get_type: Option<String> is enough

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 6, 2018

Member

While at it, I would add the same for ref/copy/unref/free functions the same way. That allows me to get rid of some more manual bindings

Member

sdroege commented Jul 6, 2018

While at it, I would add the same for ref/copy/unref/free functions the same way. That allows me to get rid of some more manual bindings

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 6, 2018

Member

Thanks in advance

Member

EPashkin commented Jul 6, 2018

Thanks in advance

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 9, 2018

Member

Updated accordingly and made use of it in object.rs a bit

Member

sdroege commented Jul 9, 2018

Updated accordingly and made use of it in object.rs a bit

Show outdated Hide outdated src/object.rs
Show outdated Hide outdated src/object.rs
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 9, 2018

Member

All green :)

Member

sdroege commented Jul 9, 2018

All green :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 9, 2018

Member

👍 then

Member

EPashkin commented Jul 9, 2018

👍 then

sdroege added some commits Jul 6, 2018

Add Object::find_property() and ::list_properties()
And implement some existing functions based on this and ParamSpec to get
rid of some unsafe code
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 9, 2018

Member

And green again :)

Member

sdroege commented Jul 9, 2018

And green again :)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 9, 2018

Member

Thanks!

Member

GuillaumeGomez commented Jul 9, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit b8b98c9 into gtk-rs:master Jul 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment