Add ParamSpec bindings #352

sdroege · 2018-07-06T06:36:57Z

No description provided.

sdroege · 2018-07-06T06:37:54Z

src/gobject/auto/param_spec.rs

+    pub struct ParamSpec(Object<ffi::GParamSpec, ffi::GParamSpecClass>);
+
+    match fn {
+        get_type => || ffi::intern(),


We need a way to override the get_type functions. This one here has a constant, G_TYPE_PARAMSPEC

sdroege · 2018-07-06T06:39:01Z

For some reason things like g_param_spec_bool, g_param_spec_int, etc (all the constructors) are not generated by GIR. Not sure yet why, @EPashkin do you have an idea? If not, I'll look later, don't spend time on it unless you want to :)

Also how would we best override the get_type function? Configuration that takes a string, and that is just put there instead of whatever the GIR says?

EPashkin · 2018-07-06T06:43:19Z

Gir_GObject.toml

+status = "generate"
+    [[object.function]]
+    name = "sink"
+    ignore = true # memory management


Please move comment to previous line

EPashkin · 2018-07-06T06:52:20Z

IMHO config string get_type: Option<String> is enough

sdroege · 2018-07-06T06:54:31Z

While at it, I would add the same for ref/copy/unref/free functions the same way. That allows me to get rid of some more manual bindings

EPashkin · 2018-07-06T06:59:37Z

Thanks in advance

sdroege · 2018-07-06T15:30:08Z

src/gobject/auto/param_spec.rs

+use translate::*;
+
+glib_wrapper! {
+    pub struct ParamSpec(Object<ffi::GParamSpec, ffi::GParamSpecClass>);


This is actually not a GObject but another fundamental type. So I guess we don't really get around manually binding this one after all...

Will update the PR accordingly

sdroege · 2018-07-09T08:35:16Z

Updated accordingly and made use of it in object.rs a bit

EPashkin · 2018-07-09T11:08:09Z

src/object.rs

                return Err(BoolError("property not found"));
-            }
+            },


comma unneeded

Strange, I still see it, and in other match self.find_property down too.
Seems you forgot to push 😉

I indeed forgot to push it, yes :) Thanks

EPashkin · 2018-07-09T11:09:38Z

src/object.rs

-            if !writeable {
-                return Err(BoolError("property is not writeable"));
-            }
+        if !pspec.get_flags().contains(::ParamFlags::WRITABLE) {


Maybe flags need check for CONSTRUCT_xxx, some properties have WRITABLE and CONSTRUCT_ONLY, so actually not writable

Thanks, good idea :) Will change in a few minutes

sdroege · 2018-07-09T13:39:10Z

All green :)

EPashkin · 2018-07-09T13:39:37Z

👍 then

GuillaumeGomez · 2018-07-09T13:46:47Z

src/param_spec.rs

+        }
+    }
+
+


Extra empty line.

GuillaumeGomez · 2018-07-09T13:46:52Z

src/param_spec.rs

+            from_glib_none(ffi::g_param_spec_variant(name.to_glib_none().0, nick.to_glib_none().0, blurb.to_glib_none().0, type_.to_glib_none().0, default_value.to_glib_none().0, flags.to_glib()))
+        }
+    }
+


Extra empty line.

And implement some existing functions based on this and ParamSpec to get rid of some unsafe code

sdroege · 2018-07-09T14:34:27Z

And green again :)

GuillaumeGomez · 2018-07-09T14:36:56Z

Thanks!

sdroege commented Jul 6, 2018

View reviewed changes

EPashkin reviewed Jul 6, 2018

View reviewed changes

sdroege commented Jul 6, 2018

View reviewed changes

EPashkin reviewed Jul 9, 2018

View reviewed changes

GuillaumeGomez reviewed Jul 9, 2018

View reviewed changes

sdroege added 3 commits July 9, 2018 15:50

Add ParamSpec bindings

bf3e82d

Add Object::find_property() and ::list_properties()

6144497

And implement some existing functions based on this and ParamSpec to get rid of some unsafe code

Add Object::connect_notify() to generically connect to the notify signal

650933d

GuillaumeGomez merged commit b8b98c9 into gtk-rs:master Jul 9, 2018

Uh oh!

Add ParamSpec bindings #352

Add ParamSpec bindings #352

Uh oh!

Conversation

sdroege commented Jul 6, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdroege commented Jul 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EPashkin commented Jul 6, 2018

Uh oh!

sdroege commented Jul 6, 2018

Uh oh!

EPashkin commented Jul 6, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdroege commented Jul 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdroege commented Jul 9, 2018

Uh oh!

EPashkin commented Jul 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdroege commented Jul 9, 2018

Uh oh!

GuillaumeGomez commented Jul 9, 2018

Uh oh!

Uh oh!

sdroege commented Jul 6, 2018 •

edited

Loading