Add downcast_ref() and similar functions for all the casting machinery #356
Conversation
|
The object ones are preventing the |
| where T: StaticType + UnsafeFrom<ObjectRef> + Wrapper, | ||
| Self: IsA<T> { | ||
| unsafe { | ||
| mem::transmute(self) |
There was a problem hiding this comment.
The object casts are safe because all the types have the same memory representation apart from their name and the phantom data type, and IsA is an unsafe trait so must only be implemented if it's actually a proper GObject wrapper type
| gobject_ffi::g_type_check_value_holds(mut_override(self.to_glib_none().0), | ||
| T::static_type().to_glib())); | ||
| if ok { | ||
| Some(mem::transmute(self)) |
There was a problem hiding this comment.
The value transmutes are safe because the only difference between Value and TypedValue is the zero-sized phantom data.
There was a problem hiding this comment.
This comment not better be in code? ;)
|
@sdroege Looks good |
|
I clearly don't know enough this part of GLib and the code looks good to me so I'll trust you and @EPashkin's opinion on this one. Thanks! |
See individual commits.