Skip to content

Conversation

ketsuban
Copy link
Contributor

@sdroege suggested I add these instructions. I won't be in the least bit offended if you want to reformat them to match a style guide or anything like that.

@GuillaumeGomez
Copy link
Member

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 2b88927 into gtk-rs:master Jun 12, 2019
@ketsuban ketsuban deleted the msvc-instructions branch June 13, 2019 00:45

```ini
[Settings]
gtk-theme-name=win32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Adwaita isn't working?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vcpkg doesn't install themes. I couldn't find any official instructions for acquiring them manually, and I didn't think telling people to manually download MinGW packages on the official website was very professional.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adwaita has been part of GTK itself for a while now, it comes as is when building gtk nothing else needed. If its broken that's a serious bug that should be investigated, not worked around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be my guest. Heckling Microsoft over their packaging infrastructure is outside my remit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, this is vcpkg, not just an msvc build. Yea, this was broken the moment it landed there, I am surprised it even runs. They did some weird autotools -> cmake translation without verifying a thing.

Apologies, thought this was linking against a local msvc build.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its broken that's a serious bug that should be investigated, not worked around.

vcpkg is known to be broken since a long time and that's why we didn't want to recommend using it. But as it's apparently still easier than the alternatives on Windows...

If someone wants to report it and list what exactly is needed: https://github.com/microsoft/vcpkg/issues/new

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I maintain that it's this issue and that this is a duplicate, but I've had no useful feedback so I don't really have any idea how to get some eyeballs on the problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can fix their vcpkg issue in any sane way, they took the autotools build and bodged it to something that wouldn't even launch when they fist announced vcpkg.

It might be easier to get them to use the meson build that has since landed for gtk3 instead.


This is [a bug](https://github.com/gtk-rs/gtk/issues/794) in version 0.6 of gtk-rs with versions of
GTK prior to 3.22.30; either use gtk-rs from Git directly or backport [the fix](https://github.com/gtk-rs/gtk/pull/804)
into the copy of gtk-rs in your Cargo registry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed now, 0.7.0 was released a while ago. Who makes a new PR? :)

@@ -29,6 +29,45 @@ The __gtk__ crate expects __GTK+__, __GLib__ and __Cairo__ development files to

## Windows

On Windows Rust can use either the MSVC toolchain or the GNU toolchain. The latter is easier to
install, but the former provides a better overall experience and allows interfacing with other
Windows libraries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is also wrong. You can interface with other Windows libraries just fine when using the GNU toolchain, as long as it's not a C++ library. But you can't interface with a C++ library directly from Rust anyway, so ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants