refactor(Music): change return type of search method in SequenceMusic class

- Change the return type of the search method in the SequenceMusic class to Collection
- Use collect function to ensure with URLs
- Filter songs with empty URLs
- Return the filtered songs collection

Author: guanguans

app/Commands/MusicCommand.php

@@ -79,14 +79,16 @@ public function handle(Timer $timer, ResourceUsageFormatter $resourceUsageFormat
                 ))->trim()->toString();
             })
             ->pipe(function () use ($timer, $keyword, &$duration): Collection {
-                $timer->start();
-                $songs = spin(
-                    fn (): array => $this->music->search($keyword, $this->option('sources')),
+                return spin(
+                    function () use ($timer, $keyword, &$duration): Collection {
+                        $timer->start();
+                        $songs = $this->music->search($keyword, $this->option('sources'));
+                        $duration = $timer->stop();
+
+                        return $songs;
+                    },
                     $this->config['searching_hint']
-                );
-                $duration = $timer->stop();
-
-                return collect($songs)->mapWithKeys(static fn ($song, $index): array => [$index + 1 => $song]);
+                )->mapWithKeys(static fn ($song, $index): array => [$index + 1 => $song]);
             })
             ->whenEmpty(function (): void {
                 warning($this->config['empty_hint']);

app/Contracts/Music.php

@@ -12,9 +12,11 @@
 
 namespace App\Contracts;
 
+use Illuminate\Support\Collection;
+
 interface Music
 {
-    public function search(string $keyword, array $sources = []): array;
+    public function search(string $keyword, array $sources = []): Collection;
 
     public function download(string $url, string $savePath): void;
 }

app/Facades/Music.php

@@ -30,7 +30,7 @@
  * @method static bool hasMacro(string $name)
  * @method static void flushMacros()
  * @method static \App\MusicManager|\Illuminate\Support\HigherOrderTapProxy tap(callable|null $callback = null)
- * @method static array search(string $keyword, array $sources = [])
+ * @method static \Illuminate\Support\Collection search(string $keyword, array $sources = [])
  * @method static void download(string $url, string $savePath)
  *
  * @see \App\MusicManager

app/Music/SequenceMusic.php

@@ -17,6 +17,7 @@
 use App\Support\Meting;
 use GuzzleHttp\Exception\GuzzleException;
 use Illuminate\Console\OutputStyle;
+use Illuminate\Support\Collection;
 use Illuminate\Support\Traits\Macroable;
 use Laravel\Prompts\Progress;
 
@@ -39,7 +40,7 @@ public function __construct(
      *
      * @throws \JsonException
      */
-    public function search(string $keyword, array $sources = []): array
+    public function search(string $keyword, array $sources = []): Collection
     {
         $withoutUrlSongs = collect($sources)
             ->map(fn (string $source): array => json_decode(
@@ -54,8 +55,7 @@ public function search(string $keyword, array $sources = []): array
         return collect($this->ensureWithUrls($withoutUrlSongs))
             ->filter()
             ->filter(static fn (array $song): bool => ! empty($song['url']))
-            ->values()
-            ->all();
+            ->values();
     }
 
     /**