Improved GeometricUtilities #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightm4re94
requested changes
Apr 6, 2020
There was a problem hiding this comment.
I see some useful utilities right here, thank you!
To comply with other nomenclatures of LITIengine, I would suggest renaming the methods to retrieve center points to getCenter(...).
Furthermore, it would be more convenient to define one base method for retrieving center points, and then let all method overloads with different parameters just call that base method instead of defining the calculations separately for each overload.
nightm4re94
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMidPoint(Line2D)getMidpoint(Point2D, Point2D)getMidPoint(double x1, double y1, double x2, double y2)getMidPoint(RectangularShape)getMidPoint(Point2D, Point2D)is more optimized now because it no longer callsgetAveragePosition(Point2D...). This is faster because an array is no longer created or iterated, and there are no unnecessary calls toPoint2D[].length