Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for Attribute, RangeAttribute and AttributeModifier #357

Merged
merged 10 commits into from
Dec 20, 2020

Conversation

jdeblander
Copy link
Contributor

@jdeblander jdeblander commented Nov 28, 2020

As I noticed that the coverage of the project is still fairly low, I wrote some unit tests for a couple of classes.
It is not much, but I hope it helps.

The classes involved are:

If anything is incorrect with the PR, please let me know.

@nightm4re94 nightm4re94 merged commit 3b5e647 into gurkenlabs:master Dec 20, 2020
nightm4re94 added a commit that referenced this pull request Dec 20, 2020
- Reformat Code
- Remove public modifiers (no longer needed in JUnit 5)
- Fix code smells
- Replace Java 8 incompatible uses of `List.of()` with `Arrays.asList()`
Copy link
Member

@nightm4re94 nightm4re94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List.of() is a static method introduced with Java 9. To stay compatible with Java 8 , I've replaced its uses with Arrays.asList in 82b8ef8.

Gamebuster19901 added a commit to Gamebuster19901/litiengine that referenced this pull request Dec 20, 2020
@jdeblander jdeblander deleted the improve-test-coverage branch December 22, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants