Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testability #389

Merged
merged 18 commits into from
Apr 27, 2021
Merged

Conversation

ddreimane
Copy link
Contributor

Improving methods/classes that are hard to test.

@jluech
Copy link
Contributor

jluech commented Apr 25, 2021

force pushed rebase against current master

Copy link
Member

@nightm4re94 nightm4re94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some very useful refactorings and additions. I have not noticed any issues so far, so I'll merge this right away. Thank you!

@nightm4re94 nightm4re94 merged commit 551c346 into gurkenlabs:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants