UI updates #409
Merged
UI updates #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the table fills the whole component without pre-allocating a bunch of unused rows. Constrain the size of the buttons by fixing the size of the icons instead of using #setMaximumSize etc.
Remove manually set dimensions of components. They aren't needed. Replace the JScrollPane for the AssetTree with an OverlayScrollPane. Make the nodes of AssetTree collapsible.
Themes are mutually exclusive. Radio buttons are better suited for this case.
nightm4re94
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates darklaf to version
2.7.2, which resolves the issues with Java 16. So no more complaints that utility doesn't start in the discord.Also various small improvements to the ui. Nothing large though.
I would love to integrate the darklaf theme settings menu into utility, which would immedeatly open up the number of available themes. The only blocking point (which I can see) are the colors in the
Styleclass. All darklaf themes offer a color palette which can be used to replace most of defined values. Though for some I am not sure what their use is.