Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Export Settings' captures the state of settings when the options page was opened, missing changes made since then #83

Closed
FatOrangutan opened this issue Aug 5, 2018 · 2 comments
Closed

'Export Settings' captures the state of settings when the options page was opened, missing changes made since then #83

FatOrangutan opened this issue Aug 5, 2018 · 2 comments
Labels
bug

Comments

@FatOrangutan
Copy link

Save In v3.1.0, Firefox Nightly

STR:

  1. Open Save In's settings, either at about:addons or the moz-extension://[...]/src/options/options.html url
  2. Make some changes. Wait for the green tick to show up to ensure the change was registered.
  3. Click Export Settings

AR: changes made at step2 aren't included in the export.
gyng added a commit that referenced this issue Aug 5, 2018
@gyng
Fix export settings not exporting updated settings after changing them (
3e0871d 
#83)

#83
* Also Improve checkmark styling in options page (#84)
@gyng
Copy link
Owner

gyng commented Aug 5, 2018

Hah, I thought nobody would notice. Fixed in 3.1.2.

@gyng gyng added the bug label Aug 5, 2018
@FatOrangutan
Copy link
Author

Thanks for the speedy fix. Seems to be working. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gyng @FatOrangutan