Add Link Formatting as well as other Slack Formatting stuff #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs this to be merged: hackclub/scrapbook#15 |
Closed
|
I reimplemented link formatting (along with user & channel formatting). Is there a good case for xss prevention and Slack markdown support (if I understand this PR correctly)? |
|
not really seems to have been implemented else where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Note: Don't merge without my upcoming PR to the site.
Note 2: I don't have yarn or npm installed on my computer (school refuses to give me admin permissions so ya), could someone run the commands to update all the package things. I tried repl.it but that was acting all weird today.