Skip to content

Conversation

myronchen-git
Copy link
Member

Fixes #134

What changes did you make?

  • Added Myron Chen to the "read-only-group" AWS group for project "devops-security".
  • Added Myron Chen to the Terraform README/docs.

Why did you make the changes (we will use this info to test)?

  • This is a part of the onboarding process to add me to the team.

Added Myron Chen to the "read-only-group" AWS group for project
"devops-security".

Added Myron Chen to the Terraform README/docs.
Copy link

github-actions bot commented Sep 25, 2025

Terraform plan in terraform
With backend config files: terraform/prod.backend.tfvars

Plan: 3 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # module.iam_user_myronchen-git.aws_iam_user.user will be created
+   resource "aws_iam_user" "user" {
+       arn           = (known after apply)
+       force_destroy = false
+       id            = (known after apply)
+       name          = "myronchen-git"
+       path          = "/"
+       tags          = {
+           "Access Level" = "1"
+           "Project"      = "devops-security"
        }
+       tags_all      = {
+           "Access Level" = "1"
+           "Project"      = "devops-security"
        }
+       unique_id     = (known after apply)
    }

  # module.iam_user_myronchen-git.aws_iam_user_group_membership.user_group_membership will be created
+   resource "aws_iam_user_group_membership" "user_group_membership" {
+       groups = [
+           "read-only-group",
        ]
+       id     = (known after apply)
+       user   = "myronchen-git"
    }

  # module.iam_user_myronchen-git.aws_iam_user_login_profile.user_login will be created
+   resource "aws_iam_user_login_profile" "user_login" {
+       encrypted_password      = (known after apply)
+       id                      = (known after apply)
+       key_fingerprint         = (known after apply)
+       password                = (sensitive value)
+       password_length         = 20
+       password_reset_required = true
+       user                    = "myronchen-git"
    }

Plan: 3 to add, 0 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.iam_oidc_gha_incubator.aws_iam_role.github_actions_oidc,
  on modules/aws-gha-oidc-providers/main.tf line 54, in resource "aws_iam_role" "github_actions_oidc":
  54:   managed_policy_arns = var.policy_arns

managed_policy_arns is deprecated. Use the aws_iam_role_policy_attachment
resource instead. If Terraform should exclusively manage all managed policy
attachments (the current behavior of this argument), use the
aws_iam_role_policy_attachments_exclusive resource as well.

✅ Plan applied in Apply Terraform changes on merge #33

@myronchen-git
Copy link
Member Author

Notes on redoing this onboarding:

  1. I skipped reinstalling AWS CLI and Terraform.

  2. My username has capitals, but my S3 and DynamoDB resource names have all lowercases.

  3. My GitHub handle has a dash, while every other team member does not. Only one other team member has a period.

  4. I reused my branch, 129-add-new-iam-user.

  5. I reused issue Create new AWS user account #134.

@myronchen-git
Copy link
Member Author

I've delve into the github-actions bot's workflow and looked at the log file. It is adding back objects that were deleted outside of Terraform (link).

@ale210 ale210 closed this Oct 9, 2025
@ale210 ale210 reopened this Oct 9, 2025
@ale210 ale210 merged commit 057b274 into main Oct 9, 2025
2 checks passed
@ale210 ale210 deleted the 129-add-new-iam-user branch October 9, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create new AWS user account

2 participants