Disable HSTS IncludeSubdomain, to prevent unexpected behavior #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: change default setting from `true` to `false` Signed-off-by: BoHong Li <raccoon@hackmd.io>
a60814billy
force-pushed
the
feature/disable-include-subdomain-hsts
branch
from
5fb5a7b to
40b6b06
Compare
a60814billy
changed the title
|
Thanks @a60814billy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking change !!!
This PR change HSTS IncludeSubdomain setting to false.
In default setting, its will force subdomain use HSTS, but it's breaking the site that hosted in subdomain and didn't has SSL certificate.