Only show new guest note button i if anonymous editing is enabled #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there are two different settings: allowAnonymous and allowAnonymousEdits, only show new guest note button in the latter case. Same for publishing a note: if allowAnonymousEdits is not enabled, it makes no sense to allow publishing a revision. Signed-off-by: Alexander Bokovoy <ab@vda.li>
Closed
| useCDN: config.usecdn | ||
| useCDN: config.usecdn, | ||
| allowAnonymousEdits: false, | ||
| signin: false |
There was a problem hiding this comment.
Shouldn't these newly added options get a useful value instead of being statically set to false?
There was a problem hiding this comment.
in their context we only have a response object, res. If that object can allow them to be derived from something -- fine. I was not able to find out what I can derive them from.
As this is just about displaying an error message, I think it is OK to not display the edit/publish buttons but we have to have variables defined to avoid throwing an error in the EJS code that references them.
|
After testing it and revisiting what the option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are two different settings: allowAnonymous and
allowAnonymousEdits, only show new guest note button in the latter case.
Same for publishing a note: if allowAnonymousEdits is not enabled, it makes no
sense to allow publishing a revision.
Signed-off-by: Alexander Bokovoy ab@vda.li