Skip to content

Conversation

abbra
Copy link

@abbra abbra commented Feb 19, 2018

This pull request adds support for signing into a Hackmd site with a custom identity provider based on Ipsilon. This allows integrating Hackmd with identity management solutions like FreeIPA or anything LDAP-based on POSIX systems via SSSD.

A benefit of doing so is in reusing existing identity management infrastructure that might be already deployed privately. Both Ipsilon and FreeIPA are free software.

@abbra abbra force-pushed the support-ipsilon-openidc branch from f4be4f5 to 0fd3915 Compare February 19, 2018 08:23
@abbra
Copy link
Author

abbra commented Feb 19, 2018

It looks like Travis is broken (the same test failed in an unrelated pull request as well).

@SISheogorath
Copy link
Contributor

Yes, unrelated to the pullrequest. Already saw it during the weekend. Will be fixed once I have time again. Then I should also find the time to review this (around next week).

I'm sorry that it takes so long.

@SISheogorath SISheogorath added feature Wants to add a new feature auth provider labels Feb 19, 2018
@abbra abbra force-pushed the support-ipsilon-openidc branch from 0fd3915 to 2843922 Compare February 19, 2018 11:14
@abbra
Copy link
Author

abbra commented Feb 19, 2018

@SISheogorath thanks. A second patch should probably get into a separate pull request, I'll do that.

@SISheogorath
Copy link
Contributor

Yes, can you please push it into an own branch? I really like your work!

@abbra abbra force-pushed the support-ipsilon-openidc branch from 2843922 to 8c88dcb Compare February 19, 2018 11:35
@abbra
Copy link
Author

abbra commented Feb 19, 2018

Done. Solved a conflict with README.md which was just pushed and moved anonymous editing into a separate pull request #734

@abbra abbra force-pushed the support-ipsilon-openidc branch from 8c88dcb to dda4ebd Compare May 17, 2018 19:24
Ipsilon Project (https://ipsilon-project.org/) is a server and a toolkit to
configure Apache-based Service Providers.

Support sign-in via Ipsilon OpenID Connect Identity Provider.
On the Ipsilon side an actual authentication and identity source can be
flexibly configured. We expect only three fields to be provided as part of the
UserInfo by the Ipsilon:

 - user name (subject): an account name for an authenticated user
 - email for the user
 - _groups: list of groups this user is a member of

The Ipsilon authenticator is structured similarly to 'SAML' authenticator but
is simpler to configure.

Signed-off-by: Alexander Bokovoy <ab@vda.li>
@abbra abbra force-pushed the support-ipsilon-openidc branch from dda4ebd to c33864a Compare May 17, 2018 19:29
@abbra
Copy link
Author

abbra commented May 17, 2018

@SISheogorath could you please review this PR? It is sitting for three months already. I'm using this in production for my own setup all this time without any problems.

@SISheogorath
Copy link
Contributor

Sorry for the long delay. I already reviewed it earlier but didn't write stuff down.

We run into a problem right now, which is that there are more and more Id providers push into HackMD, invoke more dependencies and this way cause maintenance to become harder over time.

Can we change this PR to become a common OpenID provider. As Ipsilon uses OIDC anyways, we can also just build the generic way. This could simplify maintaining things a lot.

@SISheogorath
Copy link
Contributor

A more universal way to use OpenID was implemented by 9f9c408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth provider feature Wants to add a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants