Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sketch: Create circle via radius #1060

Closed
WCarlsson opened this issue Apr 25, 2022 · 1 comment · Fixed by #1063
Closed

Sketch: Create circle via radius #1060

WCarlsson opened this issue Apr 25, 2022 · 1 comment · Fixed by #1063
Assignees
@Hallbergs @Tolfx
Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality
Milestone
3.10

Comments

@WCarlsson
Copy link

Is your feature request related to a problem? Please describe.
In the old draw-plugin it was possible to create circles by inputing a radius.

Describe the solution you'd like
Implement the feature in the new draw-plugin. Easiest could be in a similiar way to the old version. If the object to be drawn is a circle a new voluntary parameter is shown where the user can write the desired radius. If no value is written the
@jacobwod jacobwod added module:client/plugin Functionality that goes into plugins in client idea labels Apr 25, 2022
@jacobwod jacobwod added this to the 3.x milestone Apr 25, 2022
@WCarlsson WCarlsson changed the title Draw: Create circle via radius Sketch: Create circle via radius Apr 25, 2022
@Hallbergs Hallbergs self-assigned this Apr 27, 2022
@Hallbergs
Copy link
Member

Just a heads up (so no one else starts working on this issue): got my trainee working on this one.

@Hallbergs Hallbergs added new feature Request for adding/changing functionality and removed idea labels Apr 27, 2022
@Tolfx Tolfx self-assigned this Apr 27, 2022
Tolfx added a commit that referenced this issue Apr 27, 2022
@Tolfx
feat: ✨ Added circleRadius setter/getter in DrawModel (#1060)
f1c4733
Tolfx added a commit that referenced this issue Apr 27, 2022
@Tolfx
feat: ✨ Including model into FeatureStyleSelector (#1060)
9875785
Tolfx added a commit that referenced this issue Apr 27, 2022
@Tolfx
feat: ✨ Rendering radius prompt for circle (#1060)
09548e6
Tolfx added a commit that referenced this issue Apr 27, 2022
@Tolfx
fix: 🎨 value => defaultValue (#1060)
9c52c57
Tolfx added a commit that referenced this issue Apr 27, 2022
@Tolfx
refactor: 🎨 Added correct addFeature method (#1060)
1a56b68 
Right now this disables the "drag and hold" method, which needs to be added to make this "click" method work as well.
Tolfx added a commit that referenced this issue Apr 27, 2022
@Tolfx
feat: ✨ Swedishfi (#1060)
c3f356a
Tolfx added a commit that referenced this issue Apr 27, 2022
@Tolfx
refactor: ✨ Fixed drag issue (#1060)
bd439c2
@Tolfx Tolfx mentioned this issue Apr 27, 2022
Merged
@Tolfx Tolfx linked a pull request Apr 27, 2022 that will close this issue
Plugin(Sketch): Radius click creation #1063
Merged
Hallbergs added a commit that referenced this issue Apr 27, 2022
@Tolfx @dependabot @Hallbergs
Plugin(Sketch): Radius click creation (#1063)
1a6a893 
* Bump moment from 2.29.1 to 2.29.2 in /new-admin (#1055)

Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.1...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: ✨ Added `circleRadius` setter/getter in DrawModel (#1060)

* feat: ✨ Including `model` into `FeatureStyleSelector` (#1060)

* feat: ✨ Rendering radius prompt for circle (#1060)

* fix: 🐛 Fixed importing of wrong model.

* fix: 🎨 `value` => `defaultValue` (#1060)

* chore: 🚧 Somewhat functional radius click method

* refactor: 🎨 Added correct `addFeature` method (#1060)

Right now this disables the "drag and hold" method, which needs to be added to make this "click" method work as well.

* feat: ✨ Swedishfi (#1060)

* refactor: ✨ Fixed drag issue (#1060)

* Makes sure to disable draw when toggling activity

* Now possible to add a circle by singleclick

* fix: 🎨 Checking if edit mode or not

* Revert "Merge remote-tracking branch 'origin' into feature/1060-draw-radius-circle-click"

This reverts commit 8c96fa0, reversing
changes made to 76827ce.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Henrik Hallberg <43059093+Hallbergs@users.noreply.github.com>
@jacobwod jacobwod modified the milestones: 3.x, 3.10 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hallbergs Hallbergs

@Tolfx Tolfx

Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality
Projects
None yet
Milestone
3.10
Development

Successfully merging a pull request may close this issue.

Plugin(Sketch): Radius click creation hajkmap/Hajk
4 participants
@jacobwod @WCarlsson @Hallbergs @Tolfx