Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin(Sketch): Radius click creation #1063

Merged
merged 16 commits into from
Apr 27, 2022
Merged

Plugin(Sketch): Radius click creation #1063

merged 16 commits into from
Apr 27, 2022

Conversation

Tolfx
Copy link
Member

@Tolfx Tolfx commented Apr 27, 2022

Issue relation: #1060

This is a fix to issue #1060, now you can click to create a circle. And it will use the radius the user has inputed as show on the image below.
image

dependabot bot and others added 16 commits April 11, 2022 06:31
@dependabot
Bump moment from 2.29.1 to 2.29.2 in /new-admin (#1055)
5c02ce9 
Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.1...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Tolfx
feat: ✨ Added circleRadius setter/getter in DrawModel (#1060)
f1c4733
@Tolfx
feat: ✨ Including model into FeatureStyleSelector (#1060)
9875785
@Tolfx
feat: ✨ Rendering radius prompt for circle (#1060)
09548e6
@Tolfx
fix: 🐛 Fixed importing of wrong model.
622f450
@Tolfx
fix: 🎨 value => defaultValue (#1060)
9c52c57
@Tolfx
chore: 🚧 Somewhat functional radius click method
95b9711
@Tolfx
refactor: 🎨 Added correct addFeature method (#1060)
1a56b68 
Right now this disables the "drag and hold" method, which needs to be added to make this "click" method work as well.
@Tolfx
feat: ✨ Swedishfi (#1060)
c3f356a
@Tolfx
refactor: ✨ Fixed drag issue (#1060)
bd439c2
@Hallbergs
Makes sure to disable draw when toggling activity
793e747
@Hallbergs
Now possible to add a circle by singleclick
b4a7b5b
@Tolfx
fix: 🎨 Checking if edit mode or not
40f7d0b
@Tolfx
Merge branch 'feature/1060-draw-radius-circle-click' of https://githu…
76827ce 
…b.com/hajkmap/Hajk into feature/1060-draw-radius-circle-click
@Tolfx
Merge remote-tracking branch 'origin' into feature/1060-draw-radius-c…
8c96fa0 
…ircle-click
@Hallbergs
Revert "Merge remote-tracking branch 'origin' into feature/1060-draw-…
cfd1e7f 
…radius-circle-click"

This reverts commit 8c96fa0, reversing
changes made to 76827ce.
@Tolfx Tolfx requested review from jacobwod and Hallbergs April 27, 2022 09:58
@Tolfx Tolfx linked an issue Apr 27, 2022 that may be closed by this pull request
Sketch: Create circle via radius #1060
Closed
jacobwod
jacobwod approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@jacobwod jacobwod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me! 👍

Hallbergs
Hallbergs approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@Hallbergs Hallbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hallbergs Hallbergs merged commit 1a6a893 into develop Apr 27, 2022
@Hallbergs Hallbergs deleted the feature/1060-draw-radius-circle-click branch April 27, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hallbergs Hallbergs Hallbergs approved these changes

@jacobwod jacobwod jacobwod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sketch: Create circle via radius
3 participants
@Tolfx @jacobwod @Hallbergs