Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark Removal Confirmation #1157

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

OlofSvahnVbg
Copy link
Collaborator

Added ConfirmationDialog.js and made changes to BookmarkView and SaveView.

@OlofSvahnVbg OlofSvahnVbg added the new feature Request for adding/changing functionality label Sep 2, 2022
@OlofSvahnVbg OlofSvahnVbg added this to the 3.11 milestone Sep 2, 2022
@OlofSvahnVbg
Copy link
Collaborator Author

@Hallbergs Requested review from you because I made changes to Sketch component.

Copy link
Member

@Hallbergs Hallbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hallbergs Hallbergs merged commit 281f7ba into develop Sep 5, 2022
@Hallbergs Hallbergs deleted the feature/1155-BookmarkRemovalConfirmation branch September 5, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for adding/changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants