Skip to content

Coverage for nullish coalescing operator #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2022
Merged

Coverage for nullish coalescing operator #1036

merged 4 commits into from
Apr 16, 2022

Conversation

devinivy
Copy link
Member

Supporting coverage for nullish coalescing operator ??. Previously it would flag false positives for coverage issues.

@devinivy devinivy added the feature New functionality or improvement label Apr 10, 2022
@devinivy devinivy added this to the 25.0.0 milestone Apr 10, 2022
kanongil
kanongil approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@kanongil kanongil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, but is this not something that should be merged into the current release line? We claim to support node versions that can use this operator.

FYI, I added a test to verify that lab can detect missing coverage on both sides.

@devinivy devinivy changed the base branch from v25 to master April 14, 2022 04:51
@devinivy
Copy link
Member Author

Yeah, you're right, it should. It will just be a bit of a rigamarole to bypass coverage for nullish coalescing on node v12, but it's worth it. On it!

@devinivy devinivy removed this from the 25.0.0 milestone Apr 14, 2022
@devinivy devinivy added this to the 24.7.0 milestone Apr 14, 2022
@kanongil kanongil mentioned this pull request Apr 16, 2022
Merged
@devinivy devinivy merged commit ee4596e into master Apr 16, 2022
@devinivy devinivy deleted the cover-nullish branch April 16, 2022 20:23
@devinivy devinivy mentioned this pull request Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanongil kanongil kanongil approved these changes

Assignees
No one assigned
Labels
feature New functionality or improvement
Projects
None yet
Milestone
24.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@devinivy @kanongil