Skip to content

Conversation

@fasterthanlime
Copy link
Collaborator

Logical follow-up to #93

@fasterthanlime fasterthanlime changed the title hring-buffet typechecks on macOS Make workspace check on non-Linux platforms Mar 1, 2023
@fasterthanlime
Copy link
Collaborator Author

fasterthanlime commented Mar 1, 2023

This is looking pretty good, I still want to get in:

  • Rename IntoSplit into IntoHalves to avoid clashing with tokio's TcpStream::into_split
  • Use bytemuck's TransparentWrapper rather than use std::mem::transmute

Setting up CI for macOS/Windows (cf. #98) can be done in a separate branch. Those probably won't run h2spec.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #97 (f27689e) into main (498d8c8) will increase coverage by 0.02%.
The diff coverage is 34.27%.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   78.18%   78.20%   +0.02%     
==========================================
  Files          28       36       +8     
  Lines        5575     5718     +143     
==========================================
+ Hits         4359     4472     +113     
- Misses       1216     1246      +30     
Impacted Files Coverage Δ
crates/hring-bingo-ktls/src/linux.rs 0.00% <0.00%> (ø)
crates/hring-bingo-ktls/src/main.rs 25.00% <0.00%> (+24.58%) ⬆️
crates/hring-buffet/src/lib.rs 85.18% <ø> (ø)
crates/hring-buffet/src/piece.rs 49.61% <ø> (ø)
crates/hring/src/h1/body.rs 88.32% <ø> (ø)
crates/hring/src/h1/client.rs 92.68% <ø> (ø)
crates/hring/src/h1/encode.rs 79.56% <ø> (ø)
crates/hring/src/h1/server.rs 80.32% <ø> (ø)
crates/hring/src/h2/encode.rs 70.12% <0.00%> (ø)
crates/hring/src/lib.rs 100.00% <ø> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fasterthanlime fasterthanlime marked this pull request as ready for review March 1, 2023 16:24
@fasterthanlime fasterthanlime added this pull request to the merge queue Mar 1, 2023
Merged via the queue into main with commit 43c912f Mar 1, 2023
@fasterthanlime fasterthanlime deleted the tests-on-mac branch March 1, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants