Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneccessary is isValidJson() check #109

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2021

await.response.json() from fetch always returns a valid json and not a string. So removed redundant call. This was not allowing HRC 721 tokens to be displayed properly.

Fetch document for reference : https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#supplying_request_options

await.response.json() from `fetch` always returns a valid json and not a string. So removed redundant call. This was not allowing HRC 721 tokens to be displayed properly. 

Fetch document for reference : https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#supplying_request_options
@ghost ghost mentioned this pull request Oct 29, 2021
@hypnagonia hypnagonia merged commit de4c841 into harmony-one:master Oct 29, 2021
@ghost
Copy link
Author

ghost commented Oct 29, 2021

@hypnagonia will this also trigger a release pipeline ?? if not it must be triggered - so that the new version is available to update / download

@sophoah
Copy link

sophoah commented Nov 1, 2021

@datpenguinclub @hypnagonia just took over this so we are still figuring out how to release the update to the chrome store.

@ghost
Copy link
Author

ghost commented Nov 1, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants