Update line heights and font sizes #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jace
reviewed
Jun 11, 2020
| font-size: $mui-base-font-size; | ||
| font-weight: $mui-base-font-weight; | ||
| line-height: $mui-base-line-height; | ||
| line-height: $mui-base-line-height-px; |
There was a problem hiding this comment.
How does this work? Does this remove px from the variable?
There was a problem hiding this comment.
Added a new line height variable in px for uniformity since the $mui-base-line-height is a ratio that is used in calculations in other places.
https://github.com/hasgeek/baseframe/pull/303/files#diff-f0cee5be043f68b99267dd6fad61a009R42
jace
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.