Skip to content

Remove full height modal. Add full height for modal forms. Fix the au… #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2020
Merged

Remove full height modal. Add full height for modal forms. Fix the au… #308

merged 1 commit into from
Jul 16, 2020

Conversation

vidya-ram
Copy link

  1. Remove 100% height for modals in mobile.
  2. Add 100% height for modals with form.
  3. Fix the autofocus value in the form template. Global variable can't be modified inside for loop so using namespace.

@vidya-ram vidya-ram requested a review from jace July 16, 2020 10:20
@vidya-ram vidya-ram merged commit ee3a6c6 into master Jul 16, 2020
@vidya-ram vidya-ram deleted the modal branch July 16, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jace jace Awaiting requested review from jace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vidya-ram