-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP 904 proto updates for token reject #367
Merged
Neeharika-Sompalli
merged 9 commits into
hashgraph:main
from
LimeChain:hip-904-token-reject-and-pending-state-proto-updates
Jun 27, 2024
Merged
HIP 904 proto updates for token reject #367
Neeharika-Sompalli
merged 9 commits into
hashgraph:main
from
LimeChain:hip-904-token-reject-and-pending-state-proto-updates
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
MiroslavGatsanoga
force-pushed
the
hip-904-token-reject-and-pending-state-proto-updates
branch
2 times, most recently
from
June 6, 2024 12:55
aa67273
to
93f8cf1
Compare
…raph#354) Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com>
MiroslavGatsanoga
force-pushed
the
hip-904-token-reject-and-pending-state-proto-updates
branch
from
June 6, 2024 12:56
93f8cf1
to
dfcf89b
Compare
…h#359) Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
MiroslavGatsanoga
force-pushed
the
hip-904-token-reject-and-pending-state-proto-updates
branch
from
June 7, 2024 12:21
eddff2b
to
5953d62
Compare
MiroslavGatsanoga
changed the title
HIP 904 proto updates for token reject and pending state
HIP 904 proto updates for token reject
Jun 7, 2024
jsync-swirlds
previously approved these changes
Jun 7, 2024
2 tasks
This was referenced Jun 10, 2024
jsync-swirlds
previously approved these changes
Jun 11, 2024
steven-sheehy
previously approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
edwin-greene
previously approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
MiroslavGatsanoga
dismissed stale reviews from steven-sheehy and jsync-swirlds
via
June 17, 2024 11:07
6f87d25
MiroslavGatsanoga
requested review from
jsync-swirlds,
edwin-greene and
steven-sheehy
June 17, 2024 11:08
jsync-swirlds
previously approved these changes
Jun 17, 2024
2 tasks
Neeharika-Sompalli
previously approved these changes
Jun 20, 2024
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
MrValioBg
dismissed stale reviews from Neeharika-Sompalli and jsync-swirlds
via
June 25, 2024 07:27
34acd0a
jsync-swirlds
approved these changes
Jun 25, 2024
Neeharika-Sompalli
approved these changes
Jun 27, 2024
iwsimon
approved these changes
Jun 27, 2024
povolev15
approved these changes
Jun 27, 2024
netopyr
added a commit
that referenced
this pull request
Jul 18, 2024
* main: (21 commits) feat: 13135 Added PlatformState protobuf representation (#349) feat: Change AddressBookService package to proto (#386) feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380) HIP 904 proto updates for token reject (#367) chore: Updated codeowners to include devops-ci (#384) feat: remove node_get_info.proto (#378) fixed INVALID_GOSSIP_CA_CERTIFICATE (#375) fix: Fixing single-letter mismatch to expectations (#373) feat: Update specification text for address book service (#346) feat: Add more response codes for Dynamic Address Book Phase 2 (#370) feat: maxAutoAssociations updates for contract transactions (#359) Added more response codes for Dynamic Address Book Phase 2 (#364) feat: Add back Dynamic Address Book Phase 2 protobufs change (#361) feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358) feat: added NodeGetInfoResponse to response.proto (#355) feat: HIP-904 maxAutoAssociations updates (#348) chore: added consensus data protobuf (#350) Added NodeGetInfo (#347) feat: Dynamic Address Book Phase 2 protobufs changes (#344) feat: define event protobufs (#338) ... # Conflicts: # services/basic_types.proto # services/schedulable_transaction_body.proto # services/token_service.proto # services/transaction_body.proto # services/transaction_receipt.proto
netopyr
added a commit
that referenced
this pull request
Jul 18, 2024
* main: (21 commits) feat: 13135 Added PlatformState protobuf representation (#349) feat: Change AddressBookService package to proto (#386) feat: add admin_key to node_create.proto, node_update.proto and node.proto (#380) HIP 904 proto updates for token reject (#367) chore: Updated codeowners to include devops-ci (#384) feat: remove node_get_info.proto (#378) fixed INVALID_GOSSIP_CA_CERTIFICATE (#375) fix: Fixing single-letter mismatch to expectations (#373) feat: Update specification text for address book service (#346) feat: Add more response codes for Dynamic Address Book Phase 2 (#370) feat: maxAutoAssociations updates for contract transactions (#359) Added more response codes for Dynamic Address Book Phase 2 (#364) feat: Add back Dynamic Address Book Phase 2 protobufs change (#361) feat: Back out protobuf-changes to dynamic address book for release 0.51 (#358) feat: added NodeGetInfoResponse to response.proto (#355) feat: HIP-904 maxAutoAssociations updates (#348) chore: added consensus data protobuf (#350) Added NodeGetInfo (#347) feat: Dynamic Address Book Phase 2 protobufs changes (#344) feat: define event protobufs (#338) ...
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add token reject transaction (#351) Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> * feat: add TokenRejectTransactionBody to transaction_body proto (#354) Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com> * feat: maxAutoAssociations updates for contract transactions (#359) Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> * chore: add status code tokenreject Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> * chore: add empty-reference status code tokenreject Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> --------- Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Signed-off-by: Valentin Valkanov <valentin.a.valkanov@gmail.com> Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Co-authored-by: Valentin Valkanov <valentin.a.valkanov@gmail.com> Co-authored-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding protobuf updates related to TokenReject transaction implementation planned for 0.52.
Notes for reviewer:
Merge this PR after hashgraph/hedera-services#13685, otherwise the build in Services
develop
branch will fail.Checklist