Externalize the generation of child records for view calls

[petreze]

Description:
Reduces code duplication and fixes several remaining details involved in externalizing child ContractCallResult's.

1️⃣ In hedera-app,

• Wires up and uses ChildRecordFinalizer to set transfer lists in the records of dispatched transactions.
• Removes ExchangeRateSet from all child record receipts (not just preceding).
• Adds record builder getters for newTotalSupply and minted serial numbers (we need this to encode output from burn/mint HTS system contract calls).

2️⃣ In contract-service,

• Adds SystemContractOperations#externalizePreemptedDispatch() method to let HtsCall implementations externalize dispatches that were pre-empted for reasons not enforced by handlers (e.g. to prevent transfers to system accounts).
• Reduces duplicate code in externalized view call results by adding an isViewCall flag to FullResult and externalizing results in HtsSystemContract.
• Adds a ContractCallRecordBuilder to FullResult so that HtsCall implementations can directly return their used ContractCallRecordBuilder.
  • Updates HtsSystemContract to add the implied synthetic ContractCallResult to such record builders.
• Makes FullResult a top-level record for readability.
• Adds HtsCall.allowsStaticFrame() and reverts in HtsSystemContract when the frame is static and this method returns false.
• Updates GrantRevokeKycTranslator to match mono-service behavior of leaving INVALID_SIGNATURE response code untouched (instead of converting to INVALID_FULL_PREFIX_SIGNATURE_FOR_PRECOMPILE).
• Fixes burn and mint return types (neither is just an int64 responseCode).
• Fixes ClassicTransfersCall to:
  1. Revert or halt on unsupported behavior.
  2. Emit ERC-style log events on transferFrom() and transferFromNFT().
  3. Consolidate multiple tokenTransferList's with the same TokenID.

3️⃣ In token-service,

• Fixes FinalizeParentRecordHandler to deduct child token transfers from the top-level record (unlike in mono-service these need to be explicitly deducted from parent).
• Reverses order of modifying allowances and token balances in AdjustFungibleTokenChangesStep to match mono-service behavior.
• Adds a ChildFinalizeContext as the base interface of FinalizeContext, with just what is needed to finalize a single child record.

4️⃣ In test-clients,

• Adds record snapshots for CryptoTransferHTSSuite
• Adds some helpers to make record assertions more flexible if needed.
• Adds ACCEPTED_MONO_GAS_CALCULATION_DIFFERENCE snapshot matching mode to allow mod-service gas calculations to differ in edge cases.
• Enables 55-ish @HapiTests.

➡️ Next steps:

• Eliminate all duplicate code in externalized call results.
• Remove type parameter from DispatchForResponseCodeHtsCall (can always just use ContractCallRecordBuilder).
• Try to replace all non-transfer HtsCall implementations with DispatchForResponseCodeHtsCall instances where custom behavior is achieved via FailureCustomizer and OutputFn instead of standalone HtsCall implementations.
• Remove blockValues, value, isStaticCall from HtsCallAttempt (these are now available on the MessageFrame passed to execute()).

Related issue(s):

• Fixes Implement calculateFees in ContractCallHandler #8920
• Fixes Generalize child record externalization on a higher level in HtsSystemContract #9848
• Fixes Fix ContractKeysHTSSuite tests #9734
• Fixes Fix E2E tests in ContractMintHTSSuite #9565

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[tinker-michaelj]

LGTM

[Neeharika-Sompalli]

Just a few questions. Not blocked by the questions. Token Service changes LGTM ! Thanks @tinker-michaelj @petreze !

[lukelee-sl]

Much simpler. Thanks for making the changes. A few minor comments but definitely non blocking

[lukelee-sl]

LGTM

[Neeharika-Sompalli]

LGTM !

[codecov]

Codecov Report

Attention: 242 lines in your changes are missing coverage. Please review.

Comparison is base (791ab23) 0.00% compared to head (6bbcf2b) 65.34%.
Report is 6 commits behind head on develop.

Files	Patch %	Lines
...ontracts/hts/transfer/ClassicTransfersDecoder.java	0.00%	41 Missing ⚠️
...tracts/hts/transfer/TransferEventLoggingUtils.java	5.40%	35 Missing ⚠️
...ken/impl/handlers/FinalizeParentRecordHandler.java	31.25%	29 Missing and 4 partials ⚠️
...contracts/hts/transfer/Erc721TransferFromCall.java	28.57%	20 Missing ⚠️
...t/impl/exec/systemcontracts/HtsSystemContract.java	47.05%	12 Missing and 6 partials ⚠️
...systemcontracts/hts/create/ClassicCreatesCall.java	42.30%	11 Missing and 4 partials ⚠️
...emcontracts/hts/transfer/ClassicTransfersCall.java	50.00%	10 Missing and 2 partials ⚠️
...ontract/impl/exec/systemcontracts/hts/HtsCall.java	15.38%	11 Missing ⚠️
...stemcontracts/hts/transfer/Erc20TransfersCall.java	41.66%	7 Missing ⚠️
...rkflows/record/SingleTransactionRecordBuilder.java	0.00%	6 Missing ⚠️
... and 21 more

Additional details and impacted files

@@              Coverage Diff               @@
##             develop    #9795       +/-   ##
==============================================
+ Coverage           0   65.34%   +65.34%     
- Complexity         0    30219    +30219     
==============================================
  Files              0     3320     +3320     
  Lines              0   126812   +126812     
  Branches           0    13182    +13182     
==============================================
+ Hits               0    82863    +82863     
- Misses             0    40739    +40739     
- Partials           0     3210     +3210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tinker-michaelj]

LGTM