feat: add node refresh subcommand #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromy-cannon
force-pushed
the
00096-solo-node-refresh
branch
from
cebf542
to
3abf501
Compare
jeromy-cannon
force-pushed
the
00096-solo-node-refresh
branch
from
a5e880a
to
6ca4c3c
Compare
E2E Test Results 1 files ± 0 10 suites ±0 13m 9s ⏱️ + 2m 8s Results for commit b27c0f5. ± Comparison against base commit 7d2499e. This pull request removes 14 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jeromy-cannon
force-pushed
the
00096-solo-node-refresh
branch
from
051de37
to
50a4287
Compare
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
jeromy-cannon
force-pushed
the
00096-solo-node-refresh
branch
from
50a4287
to
03d5632
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 77.13% 77.93% +0.80%
==========================================
Files 33 33
Lines 3415 3553 +138
Branches 636 650 +14
==========================================
+ Hits 2634 2769 +135
- Misses 781 784 +3
|
jeromy-cannon
force-pushed
the
00096-solo-node-refresh
branch
from
7df350c
to
03d5632
Compare
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…p with different configurations Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
leninmehedy
approved these changes
Apr 10, 2024
jeromy-cannon
added a commit
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
JeffreyDallas
pushed a commit
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
jeromy-cannon
added a commit
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
jeromy-cannon
added a commit
that referenced
this pull request
Apr 15, 2024
swirlds-automation
added a commit
that referenced
this pull request
Apr 19, 2024
## [0.24.0](v0.23.0...v0.24.0) (2024-04-19) ### Features * add `solo account create` account alias support ([#227](#227)) ([fe865f8](fe865f8)) * add node refresh subcommand ([#211](#211)) ([d1017d8](d1017d8)) * add node refresh subcommand ([#211](#211)) ([d38918c](d38918c)) * adding some type check ([#217](#217)) ([d055496](d055496)) * allow solo to deploy pre-configured resource profiles ([#175](#175)) ([fef8a48](fef8a48)) ### Bug Fixes * add recursive option to mkdir ([#215](#215)) ([9d9a126](9d9a126)) * address PR comments from [#211](#211) ([#224](#224)) ([6cc237c](6cc237c)) * return chart-path correctly when chart-directory is specified ([#212](#212)) ([90616cc](90616cc)) * update how documented generated ([#216](#216)) ([7d2499e](7d2499e))
|
🎉 This PR is included in version 0.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
solo node refreshsubcommand.github/workflows/flow-update-readme.yamltypocheckNetworkNodeProxyUpstopPortForwardto test for port to be closed before continuingconfig.txtto include fully qualified DNS from Kube DNSRelated Issues