fix: return chart-path correctly when chart-directory is specified #212

leninmehedy · 2024-04-09T03:46:52Z

Description

This pull request changes the following:

fix: return chart-path correctly when chart-directory is specified

Related Issues

Closes #

github-actions · 2024-04-09T03:50:45Z

Unit Test Results

1 files ±0 17 suites ±0 1m 14s ⏱️ -32s
114 tests ±0 114 ✅ ±0 0 💤 ±0 0 ❌ ±0
139 runs ±0 139 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit c8cf1c8. ± Comparison against base commit 7d2499e.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-09T21:23:40Z

E2E Test Results

1 files ±0 10 suites ±0 8m 51s ⏱️ - 1m 56s
74 tests ±0 74 ✅ ±0 0 💤 ±0 0 ❌ ±0
76 runs ±0 76 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit c8cf1c8. ± Comparison against base commit 7d2499e.

♻️ This comment has been updated with latest results.

codacy-production · 2024-04-09T21:24:07Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00% (target: -1.00%)	✅ 50.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`7d2499e`)	2870	2221	77.39%
Head commit (`c8cf1c8`)	2875 (+5)	2225 (+4)	77.39% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#212)	2	1	50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

codecov · 2024-04-09T21:25:42Z

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.10%. Comparing base (7d2499e) to head (d317afa).

❗ Current head d317afa differs from pull request most recent head c8cf1c8. Consider uploading reports for the commit c8cf1c8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   77.13%   77.10%   -0.03%     
==========================================
  Files          33       33              
  Lines        3415     3416       +1     
  Branches      636      636              
==========================================
  Hits         2634     2634              
- Misses        781      782       +1

Files	Coverage Δ
version.mjs	`100.00% <100.00%> (ø)`
src/commands/base.mjs	`89.65% <0.00%> (-3.21%)`	⬇️

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

This reverts commit 1f11fdd. Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

## [0.24.0](v0.23.0...v0.24.0) (2024-04-19) ### Features * add `solo account create` account alias support ([#227](#227)) ([fe865f8](fe865f8)) * add node refresh subcommand ([#211](#211)) ([d1017d8](d1017d8)) * add node refresh subcommand ([#211](#211)) ([d38918c](d38918c)) * adding some type check ([#217](#217)) ([d055496](d055496)) * allow solo to deploy pre-configured resource profiles ([#175](#175)) ([fef8a48](fef8a48)) ### Bug Fixes * add recursive option to mkdir ([#215](#215)) ([9d9a126](9d9a126)) * address PR comments from [#211](#211) ([#224](#224)) ([6cc237c](6cc237c)) * return chart-path correctly when chart-directory is specified ([#212](#212)) ([90616cc](90616cc)) * update how documented generated ([#216](#216)) ([7d2499e](7d2499e))

swirlds-automation · 2024-04-19T15:26:28Z

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation · 2024-04-27T23:22:00Z

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

leninmehedy requested a review from a team as a code owner April 9, 2024 03:46

leninmehedy requested a review from tomzhenghedera April 9, 2024 03:46

leninmehedy requested a review from jeromy-cannon April 9, 2024 03:50

leninmehedy requested a review from a team as a code owner April 9, 2024 03:52

tomzhenghedera previously approved these changes Apr 9, 2024

View reviewed changes

jeromy-cannon previously approved these changes Apr 9, 2024

View reviewed changes

leninmehedy dismissed stale reviews from jeromy-cannon and tomzhenghedera via d317afa April 9, 2024 21:11

leninmehedy force-pushed the fix-chart-path branch from 44563ce to d317afa Compare April 9, 2024 21:11

leninmehedy requested a review from jeromy-cannon April 9, 2024 21:11

leninmehedy and others added 5 commits April 10, 2024 11:36

fix: return chart-path correctly when chart-directory is specified

a0302e9

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

fix: update to latest FST chart version v0.24.3

0181e7d

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

auto update README.md

8bc9d72

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

Revert "auto update README.md"

c5533af

This reverts commit 1f11fdd. Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

silence node depreciation warning

c8cf1c8

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

leninmehedy force-pushed the fix-chart-path branch from ef159d2 to c8cf1c8 Compare April 10, 2024 01:37

leninmehedy requested a review from nathanklick April 10, 2024 02:00

jeromy-cannon approved these changes Apr 10, 2024

View reviewed changes

leninmehedy merged commit 90616cc into main Apr 10, 2024
22 checks passed

leninmehedy deleted the fix-chart-path branch April 10, 2024 08:19

swirlds-automation added the released label Apr 19, 2024

swirlds-automation added the released on @0.24.x label Apr 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: return chart-path correctly when chart-directory is specified #212

fix: return chart-path correctly when chart-directory is specified #212

leninmehedy commented Apr 9, 2024

github-actions bot commented Apr 9, 2024 •

edited

Loading

github-actions bot commented Apr 9, 2024 •

edited

Loading

codacy-production bot commented Apr 9, 2024 •

edited

Loading

codecov bot commented Apr 9, 2024 •

edited

Loading

swirlds-automation commented Apr 19, 2024

swirlds-automation commented Apr 27, 2024

fix: return chart-path correctly when chart-directory is specified #212

fix: return chart-path correctly when chart-directory is specified #212

Conversation

leninmehedy commented Apr 9, 2024

Description

Related Issues

github-actions bot commented Apr 9, 2024 • edited Loading

Unit Test Results

github-actions bot commented Apr 9, 2024 • edited Loading

E2E Test Results

codacy-production bot commented Apr 9, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Apr 9, 2024 • edited Loading

Codecov Report

swirlds-automation commented Apr 19, 2024

swirlds-automation commented Apr 27, 2024

github-actions bot commented Apr 9, 2024 •

edited

Loading

github-actions bot commented Apr 9, 2024 •

edited

Loading

codacy-production bot commented Apr 9, 2024 •

edited

Loading

codecov bot commented Apr 9, 2024 •

edited

Loading