Remove deprecated `HdsMenuPrimitive` component #3224

zamoore · 2025-09-22T21:13:46Z

📌 Summary

If merged, this PR removes the deprecated HdsMenuPrimitive component.

🛠️ Detailed description

TBD

🔗 External links

Jira ticket: HDS-5509

👀 Component checklist

Percy was checked for any visual regression
A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist

If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've worked with GRC to document the impact of any changes to security controls.
Examples of changes to controls include access controls, encryption, logging, etc.
If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

vercel · 2025-09-22T21:13:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
hds-showcase	Ready	Preview	Sep 24, 2025 6:15pm
hds-website	Ready	Preview	Sep 24, 2025 6:15pm

didoo

Left a couple of comments, but not blockers.

Also, you may want to update this comment too: https://github.com/hashicorp/design-system/blob/zamoore/hds-5509/remove-deprecated-HdsMenuPrimitive/packages/components/src/styles/components/dropdown.scss#L210

packages/components/src/components/hds/dropdown/index.ts

didoo · 2025-09-23T20:43:23Z

packages/components/src/components/hds/dropdown/index.ts


 export interface HdsDropdownSignature {
-  Args: MenuPrimitiveSignature['Args'] & {
+  Args: Pick<HdsPopoverPrimitiveSignature['Args'], 'isOpen' | 'onClose'> & {


[thought] Probably a matter of personal preferences, but since it's only a couple of arguments that are picked, I would keep things simple and would use directly the PopoverPrimitive['Args']['***] values

I don't mind that change.

didoo · 2025-09-23T20:46:42Z

.changeset/legal-swans-occur.md

+"@hashicorp/design-system-components": major
+---
+
+Removed the deprecated `HdsMenuPrimitive` component


Suggested change

Removed the deprecated `HdsMenuPrimitive` component

Removed the deprecated `MenuPrimitive` component

dchyun · 2025-09-24T13:50:40Z

[Nit] The dropdown scss file has one comment that is referencing the menu primitive on line 210.

// LIST
// UL ELEMENT
// GOES INSIDE HDS::MenuPrimitive's :content block

hashibot-hds added packages/components docs-website Content updates to the documentation website showcase labels Sep 22, 2025

zamoore changed the title ~~Zamoore/hds 5509/remove deprecated hds menu primitive~~ Remove deprecated HdsMenuPrimitive component Sep 22, 2025

vercel bot had a problem deploying to Preview – hds-website September 22, 2025 21:17 Failure

vercel bot had a problem deploying to Preview – hds-showcase September 22, 2025 21:17 Failure

zamoore force-pushed the main-5.0.0 branch from 42e1aaa to 468a8bc Compare September 22, 2025 21:19

zamoore force-pushed the zamoore/hds-5509/remove-deprecated-HdsMenuPrimitive branch from a035729 to 73be271 Compare September 22, 2025 21:23

vercel bot had a problem deploying to Preview – hds-showcase September 22, 2025 21:23 Failure

vercel bot had a problem deploying to Preview – hds-website September 22, 2025 21:24 Failure

zamoore force-pushed the main-5.0.0 branch from 468a8bc to 79d8cc2 Compare September 23, 2025 12:59

zamoore force-pushed the zamoore/hds-5509/remove-deprecated-HdsMenuPrimitive branch from 73be271 to 62f0515 Compare September 23, 2025 17:43

vercel bot had a problem deploying to Preview – hds-showcase September 23, 2025 17:43 Failure

vercel bot had a problem deploying to Preview – hds-website September 23, 2025 17:44 Failure

vercel bot had a problem deploying to Preview – hds-showcase September 23, 2025 18:08 Failure

vercel bot had a problem deploying to Preview – hds-website September 23, 2025 18:08 Failure

vercel bot deployed to Preview – hds-showcase September 23, 2025 18:13 View deployment

vercel bot deployed to Preview – hds-website September 23, 2025 18:16 View deployment

vercel bot deployed to Preview – hds-showcase September 23, 2025 18:26 View deployment

vercel bot deployed to Preview – hds-website September 23, 2025 18:27 View deployment

zamoore force-pushed the main-5.0.0 branch from 79d8cc2 to 9cce42b Compare September 23, 2025 18:45

zamoore added 7 commits September 23, 2025 14:45

removed menu-primitive from the website docs

aa5a78f

removed menu primitive references from dropdown

12f8642

removed component export

ec543d8

removed template registry

5e86c00

removed scss import

d123e60

updated docs for breadcrumb

c4785fa

added a changeset

ca8f71a

zamoore force-pushed the zamoore/hds-5509/remove-deprecated-HdsMenuPrimitive branch from e73b7a3 to ca8f71a Compare September 23, 2025 18:46

vercel bot deployed to Preview – hds-showcase September 23, 2025 18:50 View deployment

vercel bot deployed to Preview – hds-website September 23, 2025 18:53 View deployment

zamoore marked this pull request as ready for review September 23, 2025 19:43

zamoore requested review from a team as code owners September 23, 2025 19:43

didoo approved these changes Sep 23, 2025

View reviewed changes

addressing PR feedback

9b8d56f

zamoore requested review from dchyun and didoo September 24, 2025 18:11

vercel bot deployed to Preview – hds-showcase September 24, 2025 18:13 View deployment

vercel bot deployed to Preview – hds-website September 24, 2025 18:15 View deployment

zamoore merged commit 81d8152 into main-5.0.0 Sep 24, 2025
16 checks passed

zamoore deleted the zamoore/hds-5509/remove-deprecated-HdsMenuPrimitive branch September 24, 2025 18:27

zamoore mentioned this pull request Sep 24, 2025

DO NOT MERGE - Main branch for v5.0.0 changes #3211

Draft

5 tasks

zamoore added a commit that referenced this pull request Sep 24, 2025

Remove deprecated HdsMenuPrimitive component (#3224)

8c88fcd

zamoore added a commit that referenced this pull request Sep 30, 2025

Remove deprecated HdsMenuPrimitive component (#3224)

e66ac25

zamoore added a commit that referenced this pull request Oct 1, 2025

Remove deprecated HdsMenuPrimitive component (#3224)

d598ba9

zamoore added a commit that referenced this pull request Oct 2, 2025

Remove deprecated HdsMenuPrimitive component (#3224)

bc77be6

zamoore added a commit that referenced this pull request Oct 3, 2025

Remove deprecated HdsMenuPrimitive component (#3224)

85ca961

zamoore added a commit that referenced this pull request Oct 3, 2025

Remove deprecated HdsMenuPrimitive component (#3224)

fb84722

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove deprecated `HdsMenuPrimitive` component #3224

Remove deprecated `HdsMenuPrimitive` component #3224

Uh oh!

zamoore commented Sep 22, 2025 •

edited by atlassian bot

Loading

Uh oh!

vercel bot commented Sep 22, 2025 •

edited

Loading

Uh oh!

didoo left a comment

Uh oh!

Uh oh!

didoo Sep 23, 2025

Uh oh!

zamoore Sep 24, 2025

Uh oh!

didoo Sep 23, 2025

Uh oh!

dchyun commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!

	Removed the deprecated `HdsMenuPrimitive` component
	Removed the deprecated `MenuPrimitive` component

Remove deprecated HdsMenuPrimitive component #3224

Remove deprecated HdsMenuPrimitive component #3224

Uh oh!

Conversation

zamoore commented Sep 22, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Summary

🛠️ Detailed description

🔗 External links

👀 Component checklist

Uh oh!

vercel bot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

didoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

didoo Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

zamoore Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

didoo Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

dchyun commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!

Remove deprecated `HdsMenuPrimitive` component #3224

Remove deprecated `HdsMenuPrimitive` component #3224

zamoore commented Sep 22, 2025 •

edited by atlassian bot

Loading

vercel bot commented Sep 22, 2025 •

edited

Loading