Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/legal-swans-occur.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": major
---

Removed the deprecated `MenuPrimitive` component
1 change: 0 additions & 1 deletion packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@
"./components/hds/layout/grid/item.js": "./dist/_app_/components/hds/layout/grid/item.js",
"./components/hds/link/inline.js": "./dist/_app_/components/hds/link/inline.js",
"./components/hds/link/standalone.js": "./dist/_app_/components/hds/link/standalone.js",
"./components/hds/menu-primitive.js": "./dist/_app_/components/hds/menu-primitive.js",
"./components/hds/modal/body.js": "./dist/_app_/components/hds/modal/body.js",
"./components/hds/modal/footer.js": "./dist/_app_/components/hds/modal/footer.js",
"./components/hds/modal/header.js": "./dist/_app_/components/hds/modal/header.js",
Expand Down
3 changes: 0 additions & 3 deletions packages/components/src/components.ts
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,5 @@ export { default as HdsDismissButton } from './components/hds/dismiss-button/ind
// Interactive
export { default as HdsInteractive } from './components/hds/interactive/index.ts';

// MenuPrimitive
export { default as HdsMenuPrimitive } from './components/hds/menu-primitive/index.ts';

// PopoverPrimitive
export { default as HdsPopoverPrimitive } from './components/hds/popover-primitive/index.ts';
9 changes: 5 additions & 4 deletions packages/components/src/components/hds/dropdown/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
} from './types.ts';

import type { ComponentLike } from '@glint/template';
import type { MenuPrimitiveSignature } from '../menu-primitive';
import type { HdsPopoverPrimitiveSignature } from '../popover-primitive/index.ts';
import type { HdsDropdownFooterSignature } from './footer';
import type { HdsDropdownHeaderSignature } from './header';
import type { HdsDropdownListItemCheckboxSignature } from './list-item/checkbox';
Expand All @@ -39,15 +39,16 @@ export const POSITIONS: HdsDropdownPositions[] = Object.values(
);

export interface HdsDropdownSignature {
Args: MenuPrimitiveSignature['Args'] & {
Args: {
height?: string;
isInline?: boolean;
isOpen?: boolean;
isOpen?: HdsPopoverPrimitiveSignature['Args']['isOpen'];
listPosition?: HdsDropdownPositions;
width?: string;
enableCollisionDetection?: HdsAnchoredPositionOptions['enableCollisionDetection'];
preserveContentInDom?: boolean;
matchToggleWidth?: boolean;
onClose?: HdsPopoverPrimitiveSignature['Args']['onClose'];
};
Blocks: {
default: [
Expand All @@ -69,7 +70,7 @@ export interface HdsDropdownSignature {
},
];
};
Element: MenuPrimitiveSignature['Element'];
Element: HTMLDivElement;
}

export default class HdsDropdown extends Component<HdsDropdownSignature> {
Expand Down
25 changes: 0 additions & 25 deletions packages/components/src/components/hds/menu-primitive/index.hbs

This file was deleted.

109 changes: 0 additions & 109 deletions packages/components/src/components/hds/menu-primitive/index.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
@use "../components/icon-tile";
@use "../components/layout"; // multiple components
@use "../components/link"; // multiple components
@use "../components/menu-primitive";
@use "../components/modal";
@use "../components/page-header";
@use "../components/pagination";
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/styles/components/dropdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ $hds-dropdown-toggle-border-radius: $hds-button-border-radius;

// LIST
// UL ELEMENT
// GOES INSIDE HDS::MenuPrimitive's :content block
// GOES INSIDE HDS::PopoverPrimitive's popover element

.hds-dropdown__content {
position: relative;
Expand Down
13 changes: 0 additions & 13 deletions packages/components/src/styles/components/menu-primitive.scss

This file was deleted.

5 changes: 0 additions & 5 deletions packages/components/src/template-registry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ import type HdsLayoutGridComponent from './components/hds/layout/grid';
import type HdsLayoutGridItemComponent from './components/hds/layout/grid/item';
import type HdsLinkInlineComponent from './components/hds/link/inline';
import type HdsLinkStandaloneComponent from './components/hds/link/standalone';
import type HdsMenuPrimitiveComponent from './components/hds/menu-primitive';
import type HdsModalBodyComponent from './components/hds/modal/body';
import type HdsModalFooterComponent from './components/hds/modal/footer';
import type HdsModalHeaderComponent from './components/hds/modal/header';
Expand Down Expand Up @@ -806,10 +805,6 @@ export default interface HdsComponentsRegistry {
'Hds::Link::Standalone': typeof HdsLinkStandaloneComponent;
'hds/link/standalone': typeof HdsLinkStandaloneComponent;

// MenuPrimitive
'Hds::MenuPrimitive': typeof HdsMenuPrimitiveComponent;
'hds/menu-primitive': typeof HdsMenuPrimitiveComponent;

// Modal
'Hds::Modal': typeof HdsModalComponent;
'hds/modal': typeof HdsModalComponent;
Expand Down
1 change: 0 additions & 1 deletion showcase/app/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ Router.map(function () {
this.route('disclosure-primitive');
this.route('dismiss-button');
this.route('interactive');
this.route('menu-primitive');
this.route('popover-primitive');
});
this.route('page-overrides', { path: 'overrides' }, function () {
Expand Down
1 change: 0 additions & 1 deletion showcase/app/styles/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@
@use "./showcase-pages/layout/flex" as showcase-layout-flex;
@use "./showcase-pages/layout/grid" as showcase-layout-grid;
@use "./showcase-pages/link-inline" as showcase-link-inline;
@use "./showcase-pages/menu-primitive" as showcase-menu-primitive;
@use "./showcase-pages/modal" as showcase-modal;
@use "./showcase-pages/page-header" as showcase-page-header;
@use "./showcase-pages/pagination" as showcase-pagination;
Expand Down
41 changes: 0 additions & 41 deletions showcase/app/styles/showcase-pages/menu-primitive.scss

This file was deleted.

5 changes: 0 additions & 5 deletions showcase/app/templates/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -369,11 +369,6 @@
Interactive
</LinkTo>
</li>
<li>
<LinkTo @route="page-utilities.menu-primitive">
MenuPrimitive
</LinkTo>
</li>
<li>
<LinkTo @route="page-utilities.popover-primitive">
PopoverPrimitive
Expand Down
Loading