Initial implementation for resource identity #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
force-pushed
the
rk/resource-identity
branch
2 times, most recently
from
6655aba to
472731f
Compare
rainkwan
changed the title
austinvalle
reviewed
Feb 12, 2025
Member
There was a problem hiding this comment.
I left some comments on the v5 stuff (skipped v6 since it's likely the same feedback).
Main thing to consider is potentially just using the existing resource routing over introducing a new resource identity routing.
Also if you'd like to add the changelogs now that's cool! (or a follow-up PR)
Member
|
I created two issues and added them to our milestones to cleanup the assertions after the next release 👍🏻 |
ansgarm
force-pushed
the
rk/resource-identity
branch
2 times, most recently
from
5ecec55 to
4c31d1f
Compare
austinvalle
reviewed
Feb 19, 2025
…th resource to UpgradeResourceIdentity tests so they can lookup the right server for that rpc
…ResourceIdentityResponse to GetResourceIdentitySchemasResponse
…lint to silence go-linter
…e identity to be implemented by the same server, so we'll always follow resources
Co-authored-by: Austin Valle <austinvalle@gmail.com>
rainkwan
force-pushed
the
rk/resource-identity
branch
from
506980a to
ab74492
Compare
austinvalle
reviewed
Feb 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new request fields and response fields to support resource identity in mux including RPCs
GetResourceIdentitySchemasandUpgradeResourceIdentity.Plugin-Go: Reference: hashicorp/terraform-plugin-go#476
TODO:
Later TODO:
ProviderServerWithResourceIdentityback toProviderServer