Add ValidateListResourceConfig RPC for List #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainkwan
changed the title
bbasata
approved these changes
Jun 11, 2025
Contributor
bbasata
left a comment
bbasata
left a comment
There was a problem hiding this comment.
Looks good to me. These review comments are non-blocking. Feel free to resolve in this PR or in a follow-up PR.
There's one correctness bit in the review comments on tfprotov5to6.go and tfprotov6to5.go.
| // resource types by calling all underlying server GetMetadata RPC and falling | ||
| // back to GetProviderSchema RPC. It is intended to only be called through | ||
| // getDataSourceServer, getEphemeralResourceServer, getFunctionServer, and getResourceServer. | ||
| // getDataSourceServer, getEphemeralResourceServer, getListResourceServer, |
| } | ||
|
|
||
| ctx = logging.Tfprotov5ProviderServerContext(ctx, server) | ||
| logging.MuxTrace(ctx, "calling downstream server") |
Contributor
There was a problem hiding this comment.
I noticed that we do not log completion of the downstream server call. No action required here – this is consistent with other RPCs in mux. Just curious 💭 if that's useful.
| //nolint:staticcheck // Intentionally verifying interface implementation | ||
| listResourceServer, ok := v6server.(tfprotov6.ProviderServerWithListResource) | ||
| if !ok { | ||
| t.Fatal("v6server should implement tfprotov6.ProviderServerWithResourceIdentity") |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Fatal("v6server should implement tfprotov6.ProviderServerWithResourceIdentity") | |
| t.Fatal("v6server should implement tfprotov6.ProviderServerWithListResource") |
1 task
rainkwan
added a commit
that referenced
this pull request
Jun 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #
Description
Adds ValidateListResourceConfig RPC from List
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No