What if ... ImportBlockWithResourceIdentity #431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bbasata
commented
Feb 13, 2025
|
|
||
| // ImportStateBlockConfig, if non-empty, supplies declarative import | ||
| // configuration. This is (?mutually exclusive of ImportStateID + ResourceName?). | ||
| ImportStateBlockConfig string |
There was a problem hiding this comment.
If we can generate config on our first try, then the usefulness of this is secondary.
bbasata
commented
Feb 13, 2025
helper/resource/testing.go
Outdated
| type ImportStateKind byte | ||
|
|
||
| const ( | ||
| TerraformImportCommand ImportStateKind = iota |
There was a problem hiding this comment.
Naming is ... naming.
There was a problem hiding this comment.
The thought is: we're expanding to 3 sub-modes of import testing. Make it explicit, not inferred.
TerraformImportCommand is what we do today & will be the compatibility default.
bbasata
commented
Feb 13, 2025
|
|
||
| return testprovider.Resource{ | ||
| CreateResponse: &resource.CreateResponse{ | ||
| NewResourceIdentityData: tftypes.NewValue( |
bbasata
commented
Feb 13, 2025
helper/resource/testing.go
Outdated
| type ImportStateKind byte | ||
|
|
||
| const ( | ||
| TerraformImportCommand ImportStateKind = iota |
There was a problem hiding this comment.
Suggested change
| TerraformImportCommand ImportStateKind = iota | |
| ImportCommandWithId ImportStateKind = iota |
bbasata
changed the title
This was referenced Mar 5, 2025
|
Closing in favor of #442. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-ref #141
cc: @austinvalle