Add additional import test modes #441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephybun
commented
Mar 5, 2025
Comment on lines
-439
to
-450
| confRequest := teststep.PrepareConfigurationRequest{ | ||
| Directory: step.ConfigDirectory, | ||
| File: step.ConfigFile, | ||
| Raw: mergedConfig, | ||
| TestStepConfigRequest: config.TestStepConfigRequest{ | ||
| StepNumber: stepIndex + 1, | ||
| TestName: t.Name(), | ||
| }, | ||
| }.Exec() | ||
|
|
||
| appliedCfg = teststep.Configuration(confRequest) | ||
|
|
There was a problem hiding this comment.
It looks like this was only ever needed and done for the import tests, so I've opted to move this into testing_new_import_state.go and pass the appliedConfig through as a string so it can be easily appended/modified based on the import mode/kind we're using in the test.
5 tasks
|
Replaced by #442 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #431
TODOs:
ImportStateVerifyIgnore,SkipDataSource,ExpectError?