This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Fix the build on GHC 7.8 #460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build on GHC 7.8
The problem is that we're using
pure
given just aMonad
constraint, which doesn't work before the Applicative-Monad-Proposal went though in GHC 7.10Currently users on 7.8 can get bad build plans involving foundation 0.0.18. Please issue a hackage metadata revision to tighten foundation 0.0.18's base bound, since it is unbuildable on GHC 7.8. The correct bound for that version would be
base >=4.8 && <5
. This means that users won't get a bad build plan. They won't get a build plan at all, which is a better outcome as it allows the solver to select another version of foundation if it's within their bounds.Hackage metadata revisions can be issued from here:
https://matrix.hackage.haskell.org/package/foundation#GHC-7.8/foundation-0.0.18
I would appreciate if this fix could be merged and released as part of 0.0.19 to reinstate GHC 7.8 support.
Thanks!