-
Notifications
You must be signed in to change notification settings - Fork 722
fix network-uri bound #11230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix network-uri bound #11230
Conversation
Someone (I won't claim it wasn't me) swapped digit in the dependency for cabal-install. But it's correct for the later tests, which makes me think it was a typo.
git-blame tells me that the current bound was committed in 2018 4aea51a, which is 1+ year before network-uri-2.6.2.0 was released (https://hackage.haskell.org/package/network-uri-2.6.2.0). So, I doubt 2.6.0.2 is a typo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the light of the corresponding issue, this looks necessary.
I wish we had a --prefer-oldest CI configuration...
I'm still poking at using special comments to trigger customized CI runs; if I can figure it out (currently it looks like I'll need or at least really want a separate job triggered only on comments, since otherwise there'll have to be magic conditionals all over the place) I could probably add one. Can't be too general, though, since it has to be written to the project file instead of passed as an option. |
Blame won't really tell you anything here, since git goes by diffs and someone accidentally re-typing the same bound won't show up as a change. |
I think |
@mergify backport 3.16 |
✅ Backports have been created
|
Someone (I won't claim it wasn't me) swapped digits in the dependency for cabal-install. But it's correct for the later tests, which makes me think it was a typo.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: