uploads blocked by overly eager package checks

[bos]

The upstream bug is haskell/cabal#2527.

The problem is that hackage has started blocking uploads of packages that conditionally use -Werror hidden behind a default-False flag, a pattern used widely in the community. I can't upload any of my numerous packages, for example.

[dcoutts]

Sorry about this, we hadn't intended to change it, or really realise that it had changed. It cam with the Cabal-1.22 version (though as I say, not clear that it was intentional).

We'll sort something out.

[bos]

I've resorted to hand-editing my .cabal files after tagging each release, so I'm not completely blocked.

[cartazio]

@dcoutts @hvr whats the status on fixing that uploading kerfuffle?

[hvr]

@cartazio afaik it's still blocked on haskell/cabal#2527

[tfausak]

I hit this problem even though I only use -Werror in my test suite: https://github.com/tfausak/flow/blob/v1.0.1/flow.cabal#L45.

[cartazio]

I thought we had the fix in cabal master. Do we need a new hackage server
deploy?

On Thursday, June 4, 2015, Taylor Fausak notifications@github.com wrote:

I hit this problem even though I only use -Werror in my test suite:
https://github.com/tfausak/flow/blob/v1.0.1/flow.cabal#L45.

—
Reply to this email directly or view it on GitHub
#360 (comment)
.

[hvr]

@cartazio the fix is actually in and deployed, and if you look at haskell/cabal#2594 you'll see that it requires -Werror-flags to be guarded behind a flag for all stanzas, including testsuites/benchmarks

[dcoutts]

Right, we deployed this already.

[bergmark]

Did this get reverted?

V~/r/aeson master> cabal upload dist/aeson-0.11.2.0.tar.gz
Hackage password:
Uploading dist/aeson-0.11.2.0.tar.gz...
Error uploading dist/aeson-0.11.2.0.tar.gz: http code 400
Error: Invalid package

'ghc-options: -Wall -Werror' makes the package very easy to break with future
GHC versions because new GHC versions often add new warnings. Use just
'ghc-options: -Wall' instead.

[bergmark]

I'll put this here as well for the record.

This was changed in haskell/cabal@cbfea2a but was never merged into the 1.22 branch so it looks like it was just cherry-picked for hackage.

Since it seems cabal 1.24 will be released soon (haskell/cabal#2527 (comment)) I'd suggest we wait for that and then upgrade Cabal in hackage-server, does that sound good? For aeson I can disable -Werror completely for this release.

[dcoutts]

@bergmark Thanks for investigating. Yes, we should be able to deploy with 1.24 very soon.

[hvr]

see also #497