Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

Add haddock option to override googleapis font URL #1211

Closed
jwaldmann opened this issue Jul 2, 2020 · 4 comments
Closed

Add haddock option to override googleapis font URL #1211

jwaldmann opened this issue Jul 2, 2020 · 4 comments
Labels
backend:web UI, UX and rendering for the web backend

Comments

@jwaldmann
Copy link

jwaldmann commented Jul 2, 2020

originally brought up here: https://gitlab.haskell.org/ghc/ghc/-/issues/18392 (not by me but I support the proposal. I would have deleted "in Debian" from the second sentence.)

Haddock produces documents using fonts from the hard-coded URL https://fonts.googleapis.com/css?family=PT+Sans:400,400i,700. Having a package downloading something from an external resource every time a user opens the documentation is considered bad practice in Debian. Lintian (an error reporting tool for Debian packages) produces the following warning:

W: privacy-breach-generic [<link rel="stylesheet" type="text/css" href="https://fonts.googleapis.com/css?family=pt+sans:400,400i,700" />] (https://fonts.googleapis.com/css?family=pt+sans:400,400i,700)

It would be great to add an option to haddock (just like --mathjax=URL) to allow users to override the hard coded fontUrl to something available locally. Debian already packages this font family (fonts-paratype package) so we could use that flag to point to them instead of Google.

@jwaldmann
Copy link
Author

Are these fonts needed at all? I have googleapis.com blocked by umatrix (naturally) and can still read and navigate haddock output. What features am I missing?

raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Oct 17, 2020
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Dec 27, 2020
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
@Kleidukos Kleidukos added the backend:web UI, UX and rendering for the web backend label Jan 4, 2021
@Kleidukos
Copy link
Member

We should ship the used fonts ourselves, if they are used at all.
Thank you for raising this.

raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Oct 9, 2021
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Oct 9, 2021
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Oct 1, 2022
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Oct 1, 2022
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Oct 1, 2022
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Sep 14, 2023
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Sep 20, 2023
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Dec 19, 2023
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Dec 19, 2023
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue Feb 22, 2024
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
@DCsunset
Copy link

DCsunset commented Mar 7, 2024

Any update on this issue? (since it's been a few years)

@Kleidukos
Copy link
Member

This ticket lives at https://gitlab.haskell.org/ghc/ghc/-/issues/18392

raspbian-autopush pushed a commit to raspbian-packages/ghc that referenced this issue May 25, 2024
Bug: haskell/haddock#1211
Bug-Debian: https://bugs.debian.org/963690


Gbp-Pq: Name haddock-remove-googleapis-fonts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend:web UI, UX and rendering for the web backend
Projects
None yet
Development

No branches or pull requests

3 participants