Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendered haddock of Eq and Ord classes are missing class methods #549

Closed
christiaanb opened this issue Aug 22, 2016 · 3 comments
Closed

Rendered haddock of Eq and Ord classes are missing class methods #549

christiaanb opened this issue Aug 22, 2016 · 3 comments

Comments

@christiaanb
Copy link
Contributor

The rendered haddock (included in the GHC 8.0.1 release) for the Eq and Ord classes are missing:

  • Their class methods
  • Their source links

See:

​http://hackage.haskell.org/package/base-4.9.0.0/docs/Data-Eq.html#t:Eq
​http://hackage.haskell.org/package/base-4.9.0.0/docs/Prelude.html#t:Eq
​http://hackage.haskell.org/package/base-4.9.0.0/docs/Data-Ord.html#t:Ord
​http://hackage.haskell.org/package/base-4.9.0.0/docs/Prelude.html#t:Ord

Other (deriviable) classes, for example Show, or Enum, do not have these problems.

I've also reported this as a GHC issue: https://ghc.haskell.org/trac/ghc/ticket/12519
@niteria niteria mentioned this issue Sep 19, 2016
Closed
@k-bx
Copy link

k-bx commented Sep 19, 2016

In #552 duplicate I've provided a repo with easy reproduction steps.

@niteria
Copy link
Contributor

niteria commented Sep 20, 2016

I have a fix here, but due to poor internet it's difficult for me to commit/send a pull request. https://ghc.haskell.org/trac/ghc/ticket/12519#comment:6

mpickering pushed a commit that referenced this issue Sep 20, 2016
@niteria @mpickering
Fix rendering of class methods for Eq and Ord
073d899 
See #549 and GHC issue #12519
bgamari pushed a commit to bgamari/haddock that referenced this issue Sep 27, 2016
@niteria @bgamari
Fix rendering of class methods for Eq and Ord
240bc38 
See haskell#549 and GHC issue #12519

(cherry picked from commit 073d899)
niteria pushed a commit to niteria/haddock that referenced this issue Nov 29, 2016
Fix haddock: internal error: links: UnhelpfulSpan
6cb2b86 
This fixes haskell#554 for me. I believe this is another fall out
of `wildcard-refactor`, like haskell#549.
@niteria niteria mentioned this issue Nov 29, 2016
Merged
@ysangkok
Copy link
Member

ysangkok commented Feb 2, 2017

I think this was fixed with 240bc38 ?

alexbiehl pushed a commit that referenced this issue Jul 2, 2017
@niteria @alexbiehl
Fix haddock: internal error: links: UnhelpfulSpan (#561)
901b327 
* Fix haddock: internal error: links: UnhelpfulSpan

This fixes #554 for me. I believe this is another fall out
of `wildcard-refactor`, like #549.

* Comment to clarify why we take the methods name location
@ulysses4ever ulysses4ever mentioned this issue Sep 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@christiaanb @k-bx @niteria @ysangkok @alexbiehl