Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Make haddock more robust to changes to the Language data type #1297

Merged
merged 1 commit into from
Feb 14, 2021

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Jan 22, 2021

With the introduction of GHC2021, the Languages data type in GHC will
grow. In preparation of that (and to avoid changing haddock with each
new language), this change makes the code handle extensions to that data
type gracefully.

(cherry picked from commit c341dd7)

@nomeata nomeata requested a review from Kleidukos January 22, 2021 15:03
@Kleidukos
Copy link
Member

Hi @nomeata, sorry for the latency! Could you please rebase your branch on the current ghc-9.0 so that you can benefit from the updated CI? :)

With the introduction of GHC2021, the `Languages` data type in GHC will
grow. In preparation of that (and to avoid changing haddock with each
new language), this change makes the code handle extensions to that data
type gracefully.

(cherry picked from commit c341dd7)
@nomeata
Copy link
Contributor Author

nomeata commented Feb 14, 2021

Done!

Copy link
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Godspeed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants