This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Make the error encountered when a package can't be found more user-friendly #369
+18
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used
getPackageDetails
to fetch information about the package providing a module. This started failing regularly when GHC moved to package keys, leading to errors of the formhaddock: internal error: expectJust getPackageDetails
(see haskell/cabal#2297, #363, #361, #353).Now we use
lookupPackage
instead, which provides the means for us to gracefully handle failure. The user should now see the slightly more helpful error,Still not great, but hopefully along with a fixed Cabal release this error should occur rather infrequently.