This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Fix: Generate pattern signatures for constructors exported as patterns #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pattern synonyms can have up to two contexts, both having a different semantic meaning: The first holds the constraints required to perform the matching, the second contains the constraints provided by a successful pattern match. When the first context is empty but the second is not it is necessary to render the first, empty context.
It is not necessary to generate the simplest type signature since it will be simplified when pretty-printed.
alexbiehl
suggested changes
Aug 6, 2017
| extractPatternSyn :: Name -> Name -> [LHsType Name] -> [LConDecl Name] -> LSig Name | ||
| extractPatternSyn nm t tvs cons = | ||
| case filter matches cons of | ||
| [] -> error "extractRecSel: constructor pattern not found" |
alexbiehl
approved these changes
Aug 6, 2017
dmalikov
added a commit
to alexbiehl/haddock
that referenced
this pull request
Aug 6, 2017
* origin/master: Fix: Generate pattern signatures for constructors exported as patterns (haskell#663)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request also fixes a bug in the representation of pattern synonyms: Since pattern synonyms have two different contexts, we must render each context even if it is empty.