This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Accumulate explicitly which modules to load for 'attachInstances' #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old approach to fixing haskell#469, while correct, consumes a lot of memory. We ended up with a HUGE 'GblRdrEnv' in 'ic_rn_gbl_env'. However, 'getNameToInstancesIndex' takes that environment and compresses it down to a much smaller 'ModuleSet'. Now, we compute that 'ModuleSet' explicitly as we process modules. That way we can just tell 'getNameToInstancesIndex' what modules to load (instead of it trying to compute that information from the interactive context).
|
Relevant issue: #462. This won't build without GHC side changes to This reduces the peak memory usage of Haddock on the
|
|
Now we have both! Precise instances and more efficient memory usage! |
|
Ping? Is there no hope of this making it into 8.6? |
|
Hmmm. https://phabricator.haskell.org/D5003 hasn't been merged yet. Ping @bgamari |
|
@alexbiehl in general I can't merge this sort of thing until the Haddock patch has merged. Afterall, otherwise I can't bump the submodule. |
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
May 17, 2024
…nstances Accumulate explicitly which modules to load for 'attachInstances'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old approach to fixing #469, while correct, consumes a lot of
memory. We ended up with a HUGE
GblRdrEnvinic_rn_gbl_env. However,getNameToInstancesIndextakes that environment and compresses it downto a much smaller
ModuleSet.Now, we compute that
ModuleSetexplicitly as we process modules. Thatway we can just tell
getNameToInstancesIndexwhat modules to load(instead of it trying to compute that information from the interactive
context).