This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Follow GHC HEAD's HsTypes.Promoted -> BasicTypes.PromotionFlag change #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It got introduced in ghc/ghc@ae2c9b4.
|
Thanks! We should probably also port over to the various backends the pretty-printing logic that SPJ added, but let's start by unbreaking things... |
bgamari
pushed a commit
to ghc/ghc
that referenced
this pull request
Nov 16, 2018
Summary: ae2c9b4 introduced some changes that broke haddock, [1] fixed them and this patch bumps the haddock submodule to include the fixes. [1]: haskell/haddock#970 Test Plan: build haddock (make or hadrian) Reviewers: bgamari, AndreasK Reviewed By: AndreasK Subscribers: osa1, AndreasK, rwbarton, carter GHC Trac Issues: #15900 Differential Revision: https://phabricator.haskell.org/D5341
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
May 17, 2024
…onflag Follow GHC HEAD's HsTypes.Promoted -> BasicTypes.PromotionFlag change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It got introduced in ghc/ghc@ae2c9b4 and without the patch from this PR, we cannot build haddock.