Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split main Tactics module #1391

Merged
merged 41 commits into from
Feb 17, 2021
Merged

Split main Tactics module #1391

merged 41 commits into from
Feb 17, 2021

Conversation

isovector
Copy link
Collaborator

I have a rule that functions should be less than ten lines long, and under no circumstances should there be 50+ imports. This module broke all the rules, so I broke it.

@isovector
Agda splitting machinery
4552fb8
@isovector
Expand decls!
81c7411
@isovector
Only very top-level lambda to args
bf4e670
@isovector
Preserve top-level args (but it doesnt work very well)
ee2094e
@isovector
Preserve existing patterns and matches when agdasplitting
cf75b1e
@isovector
Add traceFX debug function
14fa9f6
@isovector
Force a few iterations of splitAgda
f3ea83f
@isovector
Merge branch 'master' into agda-case-split
0e120de
@isovector
Cleanup imports
d573e7a
@isovector
Put wildcard patterns in for unused variables
de541c2
@isovector
Update tests
af02f05
@isovector
Agda-unfold on instance deps
6a5f2e4
@isovector
wildify at the very end of simplifying
5a38557
@isovector
Haddock for top-level functions
e78549c
@isovector
Move case splitting stuff into its own module
cca1f34
@isovector
Exactprint comments
8fcb936
@isovector
Haddock for casesplit
41c7461
@isovector
Use PatCompat
c6112c4
@isovector
Remove HsDumpAst
57c2da2
@isovector
Use Pat, not LPat
0d698aa
@isovector
More massaging Pats
5c1f3e0
@isovector
Only unXPat on 8.0.8
96f566b
@isovector
Haddock and cleanup -Wall
57e906f
@isovector
Cleanup sus errors
b857ca7
@isovector
Fix parse errors in GHC > 8.8
3ea09c3
@isovector
Merge branch 'master' into agda-case-split
5348c61
@isovector
Update comment around unXPat
b2236b8
@isovector
Cleanup ExactPrint to split FunBind matches
1261489
@isovector
Minor haddock tweak
d8a8198
@isovector
Bad suggest, hlint
529e4dd
jneira
jneira approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like those rules 😄

hlint should let add them (max function/module loc)

@isovector isovector added the merge me Label to trigger pull request merge label Feb 17, 2021
@mergify mergify bot merged commit f3809b5 into haskell:master Feb 17, 2021
@isovector isovector deleted the cleanup-main-module branch May 21, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isovector @jneira