Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update LTS for GHC 8.10.6 #2138

Merged
merged 8 commits into from Sep 3, 2021

Conversation

peterbecich
Copy link
Member

@jneira
Copy link
Member

jneira commented Aug 29, 2021

thanks for the update, have you revised if any of the extra-deps could be removed?

@peterbecich
Copy link
Member Author

peterbecich commented Aug 30, 2021

Good idea, I've updated extra-deps.

I believe these are all the diffs between nightly-2021-06-14 and the new LTS, including the updated/removed extra-deps. This is a comparison of stack ls dependencies:


-Cabal 3.0.2.0
+Cabal 3.2.1.0

-bytestring-encoding 0.1.0.0
+bytestring-encoding 0.1.1.0

-clock 0.7.2
+clock 0.8.2

-ghc-api-compat 8.6.1
+ghc-api-compat 8.10.6

-ghc-check 0.5.0.4
+ghc-check 0.5.0.5

-heapsize 0.3.0
+heapsize 0.3.0.1

-monad-dijkstra 0.1.1.2
+monad-dijkstra 0.1.1.3

-semigroups 0.18.5
+semigroups 0.19.1

-some 1.0.1
+some 1.0.2

-temporary 1.2.1.1
+temporary 1.3

@peterbecich
Copy link
Member Author

peterbecich commented Aug 30, 2021

Should I make stack-8.10.6.yaml the default stack.yaml?

@peterbecich peterbecich marked this pull request as ready for review August 30, 2021 06:21
@jneira
Copy link
Member

jneira commented Aug 30, 2021

Should I make stack-8.10.6.yaml the default stack.yaml?

i think we could use directly 8.10.7, once we are sure it is stable

@jneira
Copy link
Member

jneira commented Aug 30, 2021

many thanks for revising the extra deps, it looks nice, do you think it is ready to merge (so it can be unmarked as draft?

@peterbecich
Copy link
Member Author

Sure thing, I believe it is ready to merge. Thx

@jneira
Copy link
Member

jneira commented Aug 31, 2021

nice, could you cherry-pick or apply manually 67b786c to unblock CI?

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Sep 1, 2021
jneira added a commit to jneira/haskell-language-server that referenced this pull request Sep 2, 2021
Copied from haskell#2138 stack-8.10.6.yaml

Co-authored-by: peterbecich <peterbecich@gmail.com>
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks, happy to see contributions which take care of build config files 🙂

@jneira
Copy link
Member

jneira commented Sep 2, 2021

circle ci status checks are stale, lets see if the next merge with mater fix them

@mergify mergify bot merged commit bd3a366 into haskell:master Sep 3, 2021
@peterbecich peterbecich deleted the update-lts-for-ghc-8.10.6 branch September 3, 2021 20:37
Ailrun added a commit that referenced this pull request Sep 4, 2021
* Add stack yaml for ghc-8.10.7

* support for ghc-8.10.7

* Use void as suggested by hlint

* Remove duplicate build

* Update extra-deps for ghc-8.10.7

Copied from #2138 stack-8.10.6.yaml

Co-authored-by: peterbecich <peterbecich@gmail.com>

* allow newer ghc for ghc-api-compat-8.10.6

Co-authored-by: Junyoung "Clare" Jang <jjc9310@gmail.com>
Co-authored-by: peterbecich <peterbecich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants