Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more features and demos in docs #2257

Merged
merged 6 commits into from Oct 7, 2021
Merged

Add more features and demos in docs #2257

merged 6 commits into from Oct 7, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Oct 5, 2021 •
edited by gitpod-io bot

@jneira jneira requested a review from michaelpj October 5, 2021 19:18
michaelpj
michaelpj approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! In the long run I think it would be cool to have a page per plugin which explains their features, has demos etc, and then this could link out to all those? Otherwise in the long run I think it's going to be hard for us to keep track of all our features!

docs/features.md Outdated
![Call Hierarchy in VSCode](https://github.com/haskell/haskell-language-server/raw/2857eeece0398e1cd4b2ffb6069b05c4d2308b39/plugins/hls-call-hierarchy-plugin/call-hierarchy-in-vscode.gif)


## How to show local documentation on hover
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like it belongs in a "features" list per se? It's more like "setup instructions to get this feature to work". I'm not sure where that belongs, perhaps in Configuration?

Copy link
Member Author

@jneira jneira Oct 6, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah you are right, thanks for the suggestion

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@jneira
Copy link
Member Author

jneira commented Oct 6, 2021

Nice! In the long run I think it would be cool to have a page per plugin which explains their features, has demos etc, and then this could link out to all those? Otherwise in the long run I think it's going to be hard for us to keep track of all our features!

Yeah that is the plan outlined here: #2066, will update it

jneira
jneira commented Oct 6, 2021
View reviewed changes
docs/features.md Outdated Show resolved Hide resolved
@jneira jneira added the merge me Label to trigger pull request merge label Oct 6, 2021
@mergify mergify bot merged commit 44468f1 into master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jneira @michaelpj