Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve qualified import plugin readme #2605

Merged
merged 2 commits into from Jan 20, 2022
Merged

Improve qualified import plugin readme #2605

merged 2 commits into from Jan 20, 2022

Conversation

eddiemundo
Copy link
Collaborator

@eddiemundo eddiemundo commented Jan 19, 2022 •
edited by gitpod-io bot

After seeing #2603 might as well improve the docs a little so we can maybe link to it.

@eddiemundo
Improve qualified import plugin readme
9bc684a 
After seeing #2603 might as well improve the docs a little so we can maybe link to it.
jneira
jneira approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the readme looks nice, thanks!

@michaelpj
Copy link
Collaborator

I'd love to pull these into the docs proper (so they're indexed, searchable etc.), but more content is always good!

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jan 19, 2022
@mergify mergify bot merged commit 905f8f7 into master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

@michaelpj michaelpj michaelpj approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eddiemundo @michaelpj @jneira