Wingman copy old to new #3363
Merged
Wingman copy old to new #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isovector
approved these changes
Nov 23, 2022
|
Not sure what's up with the benchmarking job 🤔 |
Maybe |
santiweight
force-pushed
the
wingman-copy-old-to-new
branch
from
8df9575
to
61a9a68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements step 2 of the plan outlined in #2971 (comment)
I've chosen to implement this in multiple MRs because it just gets the ball rolling. I have other MRs I am working on in parallel, and so implementing small chunks that I can get in parallel works better for me rn...
This MR does something really boring: it copy and pastes the code in the
olddirectory into thenewdirectory. Note that the new code doesn't actually build with 9.2.1+. I am doing this MR (instead of merging later) because it has to be done either way and I don't want to battle all of CI in one big change.Sanity check (which returns an empty diff):
diff -r old new