-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix suggestAddTypeAnnotation regex #760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderme
changed the title
fix-suggestAddTypeAnnotation regex
fix suggestAddTypeAnnotation regex
Dec 30, 2020
kderme
changed the title
fix suggestAddTypeAnnotation regex
Fix suggestAddTypeAnnotation regex
Dec 30, 2020
There are plans to make GHC produce structured errors: https://gitlab.haskell.org/ghc/ghc/-/issues/18516 |
How do we know that your fix works? A new test case in https://github.com/haskell/haskell-language-server/blob/master/ghcide/test/exe/Main.hs would be great. |
kderme
force-pushed
the
fix-suggestAddTypeAnnotation
branch
from
December 31, 2020 14:20
d853733
to
f5039f5
Compare
pepeiborra
approved these changes
Jan 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Jan 9, 2021
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com> Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a code with some warnings
The suggestion is
and it results in a wrong fix:
From the warning
it seems the
lit
is parsed as3’ • In the expression: 3 In an equation for ‘x
instead of3
since it is longer and still valid:In the expression
after it.Btw the approach here seems rather hacky. Are there any plans for ghc to give better support for fix sugestions?
tested with ghc-8.8.4