Fix #723 (Instance declarations in hs-boot files result in GHC errors) #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how do we know that this works? Can we have a test? |
|
I've updated the boot test to include an instance declaration, is this okay? |
Did you check that the extended test fails without your fix? |
|
Turns out the error only presented itself when template haskell was enabled in the module with a boot file, the test now correctly fails on master and passes with this PR. |
pepeiborra
approved these changes
Jan 5, 2021
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Jan 9, 2021
… errors) (haskell#781) * Fix haskell#723 * Update boot test to have instance declarations * Correct expected location of 'f' in boot-def-test * Missed TemplateHaskell pragma from boot test * Fix comment placement Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: Javier Neira <atreyu.bbb@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've put together a fix for #723.
The core of it is just using
mkBootModDetailsTcinstead oftidyProgramon boot files.