wrong-number-of-arguments (3 . 3), 2

[Vonfry]

It starts from commits 4d77a88.

Some details: travis-ci

cc: @purcell

[guygastineau]

I am experiencing this tonight as well.

[guygastineau]

This is line 139 of haskell-interactive-mode.el:

(define-obsolete-face-alias 'haskell-interactive-face-prompt2 'haskell-interactive-face-prompt-cont)

Unfortunately, the macro define-obsolete-face-alias requires 3 arguments.

(defmacro define-obsolete-face-alias (obsolete-face current-face when)
  "Make OBSOLETE-FACE a face alias for CURRENT-FACE and mark it obsolete.                                             
If provided, WHEN should be a string indicating when the face                                                         
was first made obsolete, for example a date or a release number."
  `(progn
     (put ,obsolete-face 'face-alias ,current-face)
     ;; Used by M-x describe-face.                                                                                    
     (put ,obsolete-face 'obsolete-face (or (purecopy ,when) t))))

[qcfu-bu]

I am having the same issue. From the way the comment in the macro is worded, it should be able to take either 2 or 3 arguments?

[guygastineau]

@qcfu-bu thank you for that clarification.

I think I didn't really read the docstrings, because I was already thinking about what the debug messages told me.

I wonder why this is happening then. I am not used to elisp macros (I'm used to scheme macros). Do elisp macros need to state optional args as optional?

[qcfu-bu]

I believe there should be an optional argument, though I may be wrong.

https://www.gnu.org/software/emacs/manual/html_node/eintr/Optional-Arguments.html

[guygastineau]

Yeah, reading some documentation it seems like &optional can be used with defmacro, so perhaps that is the problem there.

I can't actually tell where define-obsolete-face-alias is defined (I got the source from the debugger, but it came from a byte code run and it didn't give me the source location). If it is from another package, then maybe it needs to be fixed there.

I excluded the comment that preceded it in the source. That comment basically said, "the following macro doesn't do anything, and don't use it."

So I don't really know where this leaves us, but maybe that information is helpful to someone.

[jfb-ampli]

It seems to be defined in lisp/emacs-lisp/byte-run.el in the Emacs source. Seems like adding a &optional there would do the trick? I'll build and check.

[guygastineau]

@jfb-ampli thank you. Hmm, I guess I saw byte-run, and I assumed it was a compiler pass. I didn't realize that was actually a src file.

Do you know where to make a PR to patch byte-run.el if your fix works?

PS. For the time being it should work to add t as the third argument in this package, as that is what the behavior should have defaulted to anyway. I'm still not really sure what this macro is doing for the mode though...

[gbrls]

@guygastineau Can you explain a little further your workaround?

[jfb-ampli]

It did work. I'll check out how to push a patch upstream. Off to emacs-devel, I guess.

[guygastineau]

@jfb-ampli you are my hero 😍

@gbrls
It seems like @jfb-ampli is going to submit a patch to main emacs which should fix this.

In the mean time (I haven't tried this, but it should work) you can change line 139 of haskell-interactive-mode.el in this package from:

(define-obsolete-face-alias 'haskell-interactive-face-prompt2 'haskell-interactive-face-prompt-cont)

to

(define-obsolete-face-alias 'haskell-interactive-face-prompt2 'haskell-interactive-face-prompt-cont t)

---

Made a bit clearer that would be:

(define-obsolete-face-alias
 'haskell-interactive-face-prompt2
 'haskell-interactive-face-prompt-cont
 t)

We are just adding the default arg for the macro explicitly, because the macro failed to make the third argument optional. This has probably gone unnoticed, because the documentation for it says not to use the macro anyway.

[gbrls]

Just made a fork with this modification https://github.com/gbrls/haskell-mode/commit/97a33fc63547ccc1e58a9a61953bcacee3a41b0f
Updated my package.el to use it and it still throws the same error:

  (wrong-number-of-arguments (3 . 3) 2)

[qcfu-bu]

@guygastineau Your solution worked for me. From looking at the commit that broke this, it puzzles me as to what purpose define-obsolete-face-alias served since the old version didn't have this line.

[guygastineau]

@qcfu-bu exactly what I was thinking.

@gbrls I am not sure what to say. I am not really any sort of expert at emacs (in fact I just switched from doom and spacemacs to my own config). I am a Scheme/Lisp nerd, so most of the time I try to transfer those skills to elisp.